Skip to content

ci: run lint on all platforms - #502

Open
nirs wants to merge 1 commit into
RamenDR:mainfrom
nightcityblade:fix/issue-191
Open

ci: run lint on all platforms#502
nirs wants to merge 1 commit into
RamenDR:mainfrom
nightcityblade:fix/issue-191

Conversation

@nirs

@nirs nirs commented Aug 11, 2026

Copy link
Copy Markdown
Member
  • run the Go lint job on Ubuntu, Windows, and macOS
  • use the -latest runner aliases on every platform

Fixes #191

@coderabbitai

coderabbitai Bot commented Aug 11, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Summary by CodeRabbit

  • Tests

    • Expanded lint checks to run across Ubuntu, Windows, and macOS.
    • Lint results are now collected across all platforms before reporting failures.
  • Chores

    • Standardized line endings for Go source files.

Walkthrough

The change enforces LF endings for Go files and expands the lint workflow to run on Ubuntu, Windows, and macOS with failures collected across all matrix jobs.

Changes

Cross-platform lint configuration

Layer / File(s) Summary
Lint matrix and Go line endings
.gitattributes, .github/workflows/test.yaml
Go files now use LF line endings. The lint job runs on Ubuntu, Windows, and macOS with fail-fast disabled.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

Suggested reviewers: raaizik

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive No pull request description was provided, so the change rationale and scope are not documented. Add a brief description of the cross-platform lint matrix and LF line-ending enforcement.
✅ Passed checks (4 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly summarizes the main change: running the lint job on Ubuntu, Windows, and macOS.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@nirs

nirs commented Aug 11, 2026

Copy link
Copy Markdown
Member Author

@nightcityblade please fix the commit mesage:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Run lint on all platforms?

1 participant