Fix: specifying a skill lag of zero is now used. #3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when
castis performed, the skill/spell is queued with a lag value that is never zero, regardless of whether that lag is specified in the skill/spell or not. This is because zero is falsy, and I'm sure you were just trying to avoid pulling in the default lag value, which isnull. The solution is to test whether the lag is currentlynull.Additionally, there were no examples where lag was specified, which always resulted in using a default lag as found in Config. So I gave
heala default lag value so that developers are mindful of it.