-
Notifications
You must be signed in to change notification settings - Fork 0
Release/IAM-db-auth #286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
miraai
merged 8 commits into
release/PF-91-consistent-db-config
from
release/IAM-db-auth
Oct 16, 2025
Merged
Release/IAM-db-auth #286
miraai
merged 8 commits into
release/PF-91-consistent-db-config
from
release/IAM-db-auth
Oct 16, 2025
+50
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
amalsgit
commented
Oct 15, 2025
- Bump chart version to 2.2.0-rc.6
- Introduce new configuration options for AWS IAM authentication in values.yaml
- Update environment variables in templates to include AWS region, IAM username, and IAM authentication flag
…ion support - Bump chart version to 2.2.0-rc.6 - Introduce new configuration options for AWS IAM authentication in values.yaml - Update environment variables in templates to include AWS region, IAM username, and IAM authentication flag
miraai
reviewed
Oct 15, 2025
charts/studio/templates/studio/backend/database-migration-job.yaml
Outdated
Show resolved
Hide resolved
…include DB_PASS based on AWS IAM authentication setting
…lds are non-empty before constructing the JDBC connection string
miraai
reviewed
Oct 16, 2025
…e name configuration - Bump chart version to 2.2.0-rc.7 - Clear default value for keycloakDatabaseName in values.yaml - Refine Keycloak database URL construction logic in _env.tpl to ensure proper variable checks
…fault values for host, port, and database name if not explicitly set. This change improves the robustness of the JDBC URL construction in the _env.tpl file.
miraai
reviewed
Oct 16, 2025
amalsgit
commented
Oct 16, 2025
secretKey: "DATABASE_PASSWORD" | ||
# -- The database name for Keycloak user management service. | ||
# This is used by Keycloak to store its user management data. | ||
keycloakDatabaseName: "keycloak" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should bring this back right?
miraai
approved these changes
Oct 16, 2025
c6fa947
into
release/PF-91-consistent-db-config
7 of 8 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.