Skip to content

fix: prevent argument injection in OpenVPN config deletion #2086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tranquac wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: prevent argument injection in OpenVPN config deletion #2086

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions ajax/openvpn/del_ovpncfg.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,14 @@
require_once '../../includes/functions.php';

if (isset($_POST['cfg_id'])) {
$ovpncfg_id = escapeshellcmd($_POST['cfg_id']);
$ovpncfg_files = pathinfo(RASPI_OPENVPN_CLIENT_LOGIN, PATHINFO_DIRNAME).'/'.$ovpncfg_id.'_*.conf';
exec("sudo rm $ovpncfg_files", $return);
$ovpncfg_id = $_POST['cfg_id'];
// Validate cfg_id: only allow alphanumeric, hyphens, underscores (prevent path traversal and argument injection)
if (!preg_match('/^[a-zA-Z0-9_-]+$/', $ovpncfg_id)) {
echo json_encode(['return' => 'Invalid configuration ID']);
exit;
}
$ovpncfg_dir = escapeshellarg(pathinfo(RASPI_OPENVPN_CLIENT_LOGIN, PATHINFO_DIRNAME));
exec("sudo rm " . $ovpncfg_dir . "/" . escapeshellarg($ovpncfg_id . "_*.conf"), $return);
$jsonData = ['return'=>$return];
echo json_encode($jsonData);
}
Loading