Update cypress to configure default browser #1283
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'd like to set the default browser which was introduced in a 13.x version. Update it to the latest version that we can use. We can't use version 15 as it requires node 20+
Cypress chose to use the 'electron' browser by default on my machine. Some of the specs (the ones that stop code execution) don't work within electron. I think it's better to use a browser that our users are more likely to be using by default. You can still choose another browser with the -b/--browser flag when running specs.
zetter-rpf
temporarily deployed
to
previews/1283/merge
GitHub Actions
Inactive
zetter-rpf
temporarily deployed
to
previews/1283/merge
GitHub Actions
Inactive
zetter-rpf
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to https://github.com/RaspberryPiFoundation/digital-editor-issues/issues/878
It's currently not easy to run the cypress specs locally because they default to running in Electron (where they don't run correctly).
Update Cypress so we can configure a default browser.
Note that there's still a couple more things we will need to do to make it possible to run the cypress specs in the docker container to install Cypress and Chrome which is something I'm looking at.