RFC: win32: implement map from a file mapping object - #139
Open
elmarco wants to merge 3 commits into
Open
Conversation
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Make it explicit that the kept handle is the file handle, not the view for example. Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
See: RazrFalcon#138 Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
de-vri-es
reviewed
Oct 21, 2025
de-vri-es
left a comment
de-vri-es
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the PR!
Note that this is a breaking change for anyone who uses the MmapRawDescriptor directly.
Also, judging from the implementation, most of the actual work is skipped if you pass in a mapping handle.
What happens when the mmap options don't match the ones already set on the mapping handle? Will this lead to soundness issues? For example, can we end up giving a mutable slice to read-only memory?
I'm not 100% sure, but it feels like this use case can be better modeled by having an unsafe windows-only constructor directly on MmapMut/Mmap that also forces you to specify the length of the mapping. Something roughly like FromRawHandle, except we also need the mapping length.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement idea from #138