Skip to content

simplify Date-IDate atime test #7846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
tdhock wants to merge 2 commits into
base: master
Choose a base branch
from
+6 −21
Draft

simplify Date-IDate atime test #7846

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1949044
add links to Date-IDate test
tdhock Jul 26, 2026
4e0c415
in expr of Date-IDate test, remove method code, add data.table:::`-.I…
tdhock Jul 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 6 additions & 21 deletions .ci/atime/tests.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -407,33 +407,18 @@ test.list <- atime::atime_test_list(
Fast = "2715663fcf0344c3f7c73241d391d8de347bdb9d", # Merge commit of the PR that improves efficiency
expr = data.table:::as.data.table.array(arr, na.rm=FALSE)),

# Date-IDate subtraction became much slower when chooseOpsMethod.IDate was added in #7213.
"Date-IDate subtraction regression in #7213" = atime::atime_test(
N = as.integer(10^seq(1, 5, by=0.5)),
# Date-IDate became much slower when chooseOpsMethod.IDate was added in #7213.
"Date-IDate regression in #7213" = atime::atime_test(
setup = {
short_date = as.Date("2000-01-01") + seq_len(40L)
long_date = as.Date("2000-01-01") + seq_len(N)
},
Before = "84b0e32f7a1bfdd8ec3a2c4012010b3ec072b31f", # Parent of the regression commit.
Regression = "cfa9f49bd27195962573ad493a31600d173abc5c", # Merge commit of #7213 which added chooseOpsMethod.IDate.
seconds.limit = 1,
Before = "84b0e32f7a1bfdd8ec3a2c4012010b3ec072b31f", # Parent of the Regression commit (https://github.com/Rdatatable/data.table/commit/cfa9f49bd27195962573ad493a31600d173abc5c).
Regression = "cfa9f49bd27195962573ad493a31600d173abc5c", # Merge commit of regression PR (https://github.com/Rdatatable/data.table/pull/7213) which added chooseOpsMethod.IDate.
Fixed = "3376b44e549315f35118daf23676298fc941d8f3", # Merge commit of fix PR (https://github.com/Rdatatable/data.table/pull/7828).
# Reset the shared base S3 table to match the version under test (see "Caveat" in the intro above).
expr = {
ns = environment(data.table::as.IDate)
s3_table = get(".__S3MethodsTable__.", envir = baseenv())
s3_generics = c("chooseOpsMethod.IDate" = "chooseOpsMethod", "-.IDate" = "-")
for (s3_method in names(s3_generics)) {
if (exists(s3_method, envir = s3_table, inherits = FALSE)) {
rm(list = s3_method, envir = s3_table)
}
if (exists(s3_method, envir = ns, inherits = FALSE)) {
base::registerS3method(
s3_generics[[s3_method]], "IDate",
get(s3_method, envir = ns, inherits = FALSE),
envir = ns)
}
}
outer(short_date, data.table::as.IDate(long_date), `-`)
outer(short_date, data.table::as.IDate(long_date), data.table:::`-.IDate`)
}),

# https://github.com/Rdatatable/data.table/pull/7144 added the speedup code and this performance test.
Expand Down
Loading