Repository navigation
Fix/fix loader - #2
Merged
Merged
Conversation
Metro refuses a non-literal import() at build time, and the webpackIgnore comment that was there to excuse it does not survive babel-preset-expo, which strips it before Metro's dependency collector ever sees it. So an Expo web app did not fail against this package at runtime, it failed to build at all, and every such consumer had to patch the published dist to get past it. Putting the call inside a string leaves nothing for a bundler to parse and nothing to strip. It needs unsafe-eval, which is why importGlue stays the documented way out for a page under a strict CSP. The docstring above it claimed bundlers chunk the glue. They never did, since webpackIgnore told them not to.
Nothing has been published under this name yet, so the first release takes 1.0.0 rather than 0.1.0 and the changelog heading follows it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.