-
-
Notifications
You must be signed in to change notification settings - Fork 207
Support API levels for SDK extensions and add missing targets for automotive and desktop. #428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support API levels for SDK extensions and add missing targets for automotive and desktop. #428
Conversation
This PR fix this issue #429 |
@ychescale9 Should I update the changelog too? |
@TimoPtr Thanks for the contribution! Is it possible to add the sdk extension in a separate PR or is it related to these new targets? I'll take a closer look at your changes on the weekend. |
It can be two PR if you prefer. But for instance both changes are needed for the latest version of android-automotive to work. |
In that case let's do both in this PR. |
Well that's annoying 😅 . At this point I'm a bit tempted to give up on validating So the SDK platform we use would remain We can then add an optional E.g.
Please let me know what you think. |
For sure that solve the issue and it easier when Google is going to introduce something new again. |
@ychescale9 I've made the modification |
Obviously out of scope for this change, but a better way to validate the This would also save people a lot of time figuring out why the emulator doesn't run when they've requested for a system image that doesn't exist. |
@TimoPtr I just checked the output of |
That's weird on my side I don't have |
Yeah you're right, but at least the latest ext version is aligned now which definitely wasn't the cast last week. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again for your contribution!
Fixes #429.
This action is missing some targets. I am currently working into using this action into https://github.com/home-assistant/android/ and I need the
android-automotive
target. I've added all the targets that I found missing.I don't have the opportunity to test them on Github Action yet.
Added targets:
Also added
system-image-api-level
to support specifying different api-levels for platform and system images as they aren't always aligned for sdk extensions.Removed input validation on
api-level
so SDK extensions e.g.android-35-ext15
and preview API levels e.g.android-Baklava
are supported.