Do not draw aliens outside 16:9 area of the screen. #963
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ywgATustcbbs
changed the title
Contributor
Author
|
THis is kinda prototype pr. Due to the current state of the discussions, No control logic is added. Control logic could be added easily after it comes to a final agreement. In case the returned value of ShouldRenderableBeIgnored() Is modified by CE or something, it should be protected. |
Contributor
|
Since the proposed changes aim to limit cheating, they will also require substantial additional work in one of our closed-source repositories. For that reason, this PR (and all black-bar, visibility or aim restrictions PR's in general) should not be merged until both components are implemented together. I propose to convert this PR to a draft, to prevent an accidental merge. |
ywgATustcbbs
force-pushed
the
UltraWideScreenFix
branch
from
0735768 to
a63f8f4
Compare
ywgATustcbbs
force-pushed
the
UltraWideScreenFix
branch
from
a63f8f4 to
48559c0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr only blocks extra view. Egg is not an alien type. No idea if it should be fixed. Therefore, leave it as is.
Needs another pr to block jump jets, blink, nade etc.
Tested on my client. Works fine.