Skip to content

Conversation

@ReagentX
Copy link
Owner

@ReagentX ReagentX self-assigned this Jun 11, 2025
@ReagentX ReagentX added bug Something isn't working input Problems with input streams labels Jun 11, 2025
@ReagentX ReagentX requested a review from Copilot June 11, 2025 03:55
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the shutdown process and modifies how streams are managed during application exit. Key changes include:

  • Replacing Mutex with AtomicBool for shutdown signaling and adjusting thread handling in shutdown.
  • Storing thread handles and child process references in InputStream and updating error handling.
  • Improving startup error recovery to prevent unassigned stream handles.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
src/util/error.rs Updated error message for invalid commands.
src/communication/reader.rs Changed shutdown logic to use AtomicBool, join threads, and update shutdown procedure.
src/communication/input.rs Refactored CommandInput to use AtomicBool and store thread handles and child processes.
src/communication/handlers/startup.rs Enhanced error handling by matching on build_streams_from_input result.

@ReagentX ReagentX merged commit 3686072 into develop Jun 11, 2025
1 check passed
@ReagentX ReagentX deleted the feat/cs/refactor-shutdown branch June 11, 2025 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working input Problems with input streams

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Command streams with no output do not terminate correctly

2 participants