Consolidate application feedback into the update payload, refine API base URL environment configuration, and upgrade to Yarn 4.

Author: Dhirenderchoudhary

applications/script.js

@@ -5,7 +5,6 @@ import {
   showToast,
   updateApplication,
   getApplicationById,
-  addApplicationFeedback,
 } from './utils.js';
 let nextLink;
 let isDataLoading = false;
@@ -127,31 +126,20 @@ function updateUserApplication({ isAccepted, isRequestChanges = false }) {
   }
 
   const applicationStatus = isAccepted ? 'accepted' : 'rejected';
-  const payload = { status: applicationStatus };
-
-  const promises = [];
   const feedback =
     applicationTextarea && applicationTextarea.value
       ? applicationTextarea.value.trim()
       : '';
 
+  const payload = { status: applicationStatus };
   if (feedback) {
-    promises.push(
-      addApplicationFeedback(currentApplicationId, {
-        feedback,
-        status: applicationStatus,
-      }),
-    );
+    payload.feedback = feedback;
   }
 
-  promises.push(
-    updateApplication({
-      applicationId: currentApplicationId,
-      applicationPayload: payload,
-    }),
-  );
-
-  Promise.all(promises)
+  updateApplication({
+    applicationId: currentApplicationId,
+    applicationPayload: payload,
+  })
     .then(() => {
       showToastMessage({
         isDev,

applications/utils.js

@@ -117,32 +117,6 @@ async function updateApplication({ applicationPayload, applicationId }) {
   }
 }
 
-async function addApplicationFeedback(applicationId, feedbackData) {
-  try {
-    const res = await fetch(
-      `${BASE_URL}/applications/${applicationId}/feedback`,
-      {
-        method: 'PATCH',
-        credentials: 'include',
-        body: JSON.stringify(feedbackData),
-        headers: {
-          'Content-type': 'application/json',
-        },
-      },
-    );
-
-    if (!res.ok) {
-      const error = await res.json();
-      throw error;
-    }
-
-    const data = await res.json();
-    return data;
-  } catch (error) {
-    throw error;
-  }
-}
-
 function showToast({ message, type }) {
   toast.innerText = message;
 
@@ -168,7 +142,6 @@ export {
   getApplications,
   getApplicationById,
   updateApplication,
-  addApplicationFeedback,
   getIsSuperUser,
   showToast,
 };