Rename TaskResult to TaskRun #101
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhthompson
force-pushed
the
rename-task-result-to-task-run
branch
2 times, most recently
from
1ebff72 to
19a9123
Compare
jhthompson
force-pushed
the
rename-task-result-to-task-run
branch
from
19a9123 to
6decd45
Compare
|
|
|
Closing as the naming is going in another direction (per #19) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up on #19, I figured I would go through and try renaming things to see how it feels in comparison (as per the Django docs, "code talks").
I don't love
TaskRunStatus, it might be better as justTaskStatus, but that loses the association with theTaskRun/TaskResult/whatever else it might end up being named.Mainly just opening to see what everyone thinks!