Add a task_name property to DBTaskResult #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomkins
force-pushed
the
removed-task-error
branch
from
87caa7c to
e519d84
Compare
tomkins
commented
Dec 18, 2024
| @property | ||
| def task_name(self) -> str: | ||
| try: | ||
| return self.task_path.rsplit(".", 1)[1] |
There was a problem hiding this comment.
Thought: It'd be nice to keep using task.name by default, but falling back to these 2 if it's not available.
tomkins
force-pushed
the
removed-task-error
branch
from
e519d84 to
17a6dd3
Compare
|
Updated - and improved the tests a little bit this time round. |
tests/tests/test_database_backend.py
Outdated
| def test_task_name(self) -> None: | ||
| db_task_result = DBTaskResult.objects.create( | ||
| args_kwargs={"args": [], "kwargs": {}}, | ||
| task_path="tests.tasks.noop_task", |
There was a problem hiding this comment.
Suggestion: Given these tests are incredibly similar, it'd be better to use subTest to just add cases and expected values.
If a task still exists - use that for the name. However if the underlying function no longer exists - use task_path to come up with an appropriate name to show in the admin.
tomkins
force-pushed
the
removed-task-error
branch
from
17a6dd3 to
a965773
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #126
Added a fairly simple method/property to
DBTaskResultto return the task name based on the saved path in the database.This does change the name of the column in the admin from "Task" to "Task name" - let me know if that's an issue at all.