Worker pings #133
Draft
Worker pings #133
+347
−98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows them to be hostnames, which could be useful in some environments
RealOrangeOne
force-pushed
the
worker-pings
branch
from
5e6cd4b to
575baaa
Compare
This is not only more correct, but should let the process terminate sooner in a few edge cases.
It was probably a premature optimisation, and one to come back to in future
Whilst it's more CPU intensive, it should be faster.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #46
All the time a worker process is running, it reports its status to a database table. All the time those pings are coming in, the task is considered running. If the pings stop for too long, it's a sign the worker has stopped processing the task, and the task should be considered failed (and thus retried when that's implemented)
The pings are intentionally their own separate table to avoid needing rewrite the entire task row with each ping.
To do
uuid(using a hostname would be useful)