Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow fractional interval argument for database worker #83

Merged
merged 2 commits into from
Aug 2, 2024

Conversation

mgax
Copy link
Contributor

@mgax mgax commented Jul 18, 2024

Running the database worker with a fractional interval fails:

$ ./manage.py db_worker --interval=.001
...
manage.py db_worker: error: argument --interval: invalid valid_interval value: '.001'

There's a built-in way to check if a float value is an actual number (as opposed to NaN or Inf) which is math.isfinite.

@mgax mgax force-pushed the fix/fractional-interval branch from 6f2cea0 to 132f0fc Compare August 2, 2024 14:12
@mgax mgax requested a review from RealOrangeOne August 2, 2024 14:13
@mgax
Copy link
Contributor Author

mgax commented Aug 2, 2024

I think the tests are failing because branch is out of sync. Let me check.

@RealOrangeOne RealOrangeOne merged commit 66213ba into RealOrangeOne:master Aug 2, 2024
28 checks passed
@mgax mgax deleted the fix/fractional-interval branch August 2, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants