Fix linting errors #95
Conversation
| @@ -67,4 +67,4 @@ def create_connection(self, alias: str) -> BaseTaskBackend: | |||
|
|
|||
| tasks = TasksHandler() | |||
|
|
|||
| default_task_backend = ConnectionProxy(cast(Mapping, tasks), DEFAULT_TASK_BACKEND_ALIAS) | |||
| default_task_backend = cast(Any, ConnectionProxy(tasks, DEFAULT_TASK_BACKEND_ALIAS)) | |||
There was a problem hiding this comment.
I'm not super happy with casting default_task_backend to Any, but casting it to BaseTaskBackend results in dozens of Mypy errors in tests, and this would have been a much larger PR.
There was a problem hiding this comment.
Are the new errors correct errors, or is something else happening?
There was a problem hiding this comment.
They are correct, because the tests know they are referencing a DummyBackend, which has extra methods, like clear. Here's the output of just lint: https://gist.github.com/mgax/e2c1c1e603c5700209571ae4ebf04a43.
There was a problem hiding this comment.
What was the error this was causing before?
There was a problem hiding this comment.
This is from CI:
django_tasks/__init__.py:70: error: Need type annotation for "default_task_backend" [var-annotated]
django_tasks/__init__.py:70: error: Argument 1 to "ConnectionProxy" has incompatible type "Mapping[Any, Any]"; expected "BaseConnectionHandler[Never]" [arg-type]
There was a problem hiding this comment.
It looks like the ConnectionProxy types aren't quite right.
That said, I still don't think setting a public type to Any is a good idea. BaseTaskBackend is the correct type - the other uses just need their type ignored.
There was a problem hiding this comment.
The issue is likely typeddjango/django-stubs#2246, where the types were previously Any, which is why they passed.
There was a problem hiding this comment.
I've attempted to fix this upstream: typeddjango/django-stubs#2311
There was a problem hiding this comment.
It sounds like the proper fix will involve a bit of work. This issue is currently blocking the CI on django-tasks. I suggest that we merge this simple fix and open a ticket to properly type default_task_backend later.
|
Fixed in 63fcda1 |
The CI currently fails because a new version of Mypy is raising new errors.