feat: implement initial gossipsub p2p code with block and vote #691
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shariqnaiyer
approved these changes
Aug 11, 2025
varun-doshi
reviewed
Aug 11, 2025
There was a problem hiding this comment.
After rebasing and pulling after this PR was merged, the lean binary was not even running for me. Failing due to network spec not initialised. I think its because you are using beacon network spec for lean stuff and also beacon gossipsubconfig.
I have pushed the fix for this on my PR here #690
| .expect("Failed to create network service"); | ||
| let network_service = LeanNetworkService::new( | ||
| Arc::new(LeanNetworkConfig { | ||
| gossipsub_config: GossipsubConfig::default(), |
There was a problem hiding this comment.
Shouldn't this target LeanGossipsubConfig?
| } | ||
|
|
||
| pub struct LeanNetworkConfig { | ||
| pub gossipsub_config: GossipsubConfig, |
| .history_gossip(3) | ||
| .max_messages_per_rpc(Some(500)) | ||
| .duplicate_cache_time(Duration::from_secs( | ||
| SLOTS_PER_EPOCH * beacon_network_spec().seconds_per_slot * 2, |
There was a problem hiding this comment.
shouldn't this be lean_network_spec()
This was referenced Aug 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Implements first half of this issue: #671
How was it fixed?
I Implemented the gossipsub p2p code with the block and vote