Skip to content

Conversation

shariqnaiyer
Copy link
Contributor

What was wrong?

Implement is_proposer based on the proposed validator spec.

https://github.com/unnawut/leanSpec/blob/pqdevnet0-md/docs/client/validator.md

How was it fixed?

Translated the function to rust

To-Do

Copy link
Contributor

@Kayden-ML Kayden-ML left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@shariqnaiyer shariqnaiyer enabled auto-merge August 14, 2025 04:24
@shariqnaiyer shariqnaiyer added this pull request to the merge queue Aug 14, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 14, 2025
@shariqnaiyer shariqnaiyer added this pull request to the merge queue Aug 14, 2025
Merged via the queue into ReamLabs:master with commit 74dfd72 Aug 14, 2025
14 checks passed
@syjn99
Copy link
Member

syjn99 commented Aug 14, 2025

@shariqnaiyer Thank you for your work!

/// Determine if one of the keystores is the proposer for the current slot.
fn is_proposer(&self) -> Option<&LeanKeystore> {
let current_slot = get_current_slot();
let proposer_index: u64 = current_slot % lean_network_spec().num_validators;
self.keystores
.iter()
.find(|keystore| keystore.id == proposer_index as u64)
}

I think this work is duplicated of this function. I think we may deduplicate those functions.

allnil pushed a commit to loadnetwork/ream that referenced this pull request Aug 18, 2025
@shariqnaiyer shariqnaiyer deleted the feature/shariqnaiyer/is-proposer-lean branch October 16, 2025 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants