-
Notifications
You must be signed in to change notification settings - Fork 63
fix: getrandom target error in risc0 and sp1 workflow #861
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: getrandom target error in risc0 and sp1 workflow #861
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is a suitable solution
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! We might use .cargo/config.toml
for applying this at all zkVM target compilation. This config.toml
works for me:
[target.'cfg(target_os = "zkvm")']
rustflags = ["--cfg", "getrandom_backend=\"custom\""]
d33b544
to
7c6739f
Compare
It looks like both of you guys didn't read this issue #857 @shariqnaiyer @syjn99 |
I will mark this PR as fixing the issue |
@shariqnaiyer before we merge this, we should get the issues opened on hashsig/plonky3/ream first |
The following issues were made to handle this upstream: Ream: #862 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
What was wrong?
risc0 and sp1 use unsupported targets for getrandom and cause an error in our worflow
How was it fixed?
risc0/risc0#634
https://docs.rs/getrandom/latest/getrandom/#opt-in-backends
The workaround as suggested by the above issue is to use a rust flag to tell getrandom a that custom backend will be used.
We can put in the config.toml so devs don't have to add it with environment variables.
To-Do