Enable logs generated by the keylime library #779
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansasaki
requested review from
kkaarreell,
Koncpa,
sarroutbi and
sergio-correia
and removed request for
kkaarreell
|
Hi @ansasaki , thank you for the update. Is the failing test due to a slower process start or was the expected message removed? |
Remove the source of the expected logs so that it can accept both messages generated by the keylime_agent application and by the keylime library. Signed-off-by: Anderson Toshiyuki Sasaki <[email protected]>
Set the RUST_LOG=keylime_agent=trace,keylime=trace to enable log from the library as well Signed-off-by: Anderson Toshiyuki Sasaki <[email protected]>
After moving some code to the library, it is possible that some of the logs are generated there and not in the keylime_agent library. Therefore, drop the origin of the log from the expected log message. Signed-off-by: Anderson Toshiyuki Sasaki <[email protected]>
ansasaki
force-pushed
the
enable_lib_debug
branch
from
b4b9e19 to
7c3f5b7
Compare
The expected messages were not removed, but since the code was moved in the PR (keylime/rust-keylime#1018) to the Basically, the |
kkaarreell
approved these changes
Jun 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR keylime/rust-keylime#1018 moves code from the
keylime-agentapplication to thekeylimelibrary.This makes it necessary to set the log level for both the application and the library so that the messages are logged as expected.
This also changes the
sanity/keylime-secure_mounttest to ignore the source of the expected log.