fix(subnav): improve accessibility with nested list when <rh-navigation-link> is slotted#2683
Merged
Merged
Conversation
zeroedin
changed the title
<rh-navigation-link> as child, improve accessibility with nested list.<rh-navigation-link> as child, improve accessibility with nested list.
zeroedin
changed the title
<rh-navigation-link> as child, improve accessibility with nested list.<rh-navigation-link>
zeroedin
marked this pull request as ready for review
October 28, 2025 20:48
zeroedin
changed the title
<rh-navigation-link><rh-navigation-link> is slotted
adamjohnson
requested changes
Oct 29, 2025
adamjohnson
left a comment
adamjohnson
left a comment
Collaborator
There was a problem hiding this comment.
Many of my comments here may not be directly tied to this PR and could be broken off into separate issues if necessary.
That said, the issue regarding "Scroll forward/back" buttons not showing on the basic demo should be addressed.
github-project-automation
Bot
moved this from In Progress 🟢
to Review 🔍
in Red Hat Design System
bennypowers
approved these changes
Oct 30, 2025
adamjohnson
approved these changes
Oct 30, 2025
adamjohnson
left a comment
adamjohnson
left a comment
Collaborator
There was a problem hiding this comment.
Links Get Thoroughly Modernized
github-project-automation
Bot
moved this from Review 🔍
to Done ☑️
in Red Hat Design System
zeroedin
added a commit
that referenced
this pull request
Oct 31, 2025
* fix(health-index): use status tokens for border, background, and text colors (#2566) * fix(health-index): use status tokens for colors * refactor(health-index): unshorten variable names “Programs must be written for people to read, and only incidentally for machines to execute.” * chore(health-index): add changeset * refactor(health-index): use t-shirt sizes for lg/large variable * fix(pagination): inactive disabled button dark scheme color (#2589) * fix(pagination): update dark scheme disabled button background color * chore(pagination): add changeset * feat(back-to-top): add dark color scheme support (#2571) * feat(back-to-top): add dark color scheme support * chore(back-to-top): add changeset * fix(back-to-top): move custom element inside context demo element, nix outdated CSS * refactor(back-to-top): condense border CSS * docs(back-to-top): update style page * docs(back-to-top): update Guidelines page * docs(back-to-top): update Accessibility page * feat(avatar): add ability to use a bordered avatar (#2570) * feat(avatar): add bordered variant * docs(avatar): fix description for `layout` prop * docs(avatar): document `part` attributes on the Code page * fix(avatar): remove empty string from `variant` prop * chore(avatar): add changeset * chore(avatar): update changeset to minor, tweak content * docs(avatar): update Style docs * docs(avatar): update Guidelines page * docs(avatar): update related items / components * docs(avatar): style anatomy correction * fix(pagination): change inactive stepper icon color (#2596) * fix(pagination): add `--rh-color-icon-status-disabled` token * chore(pagination): add changeset * fix(pagination): make open variant stepper background transparent * fix(pagination): update rh-color-icon-status-disabled light scheme color * fix(tabs): update the background color of inactive box variant tabs (#2593) * fix(tabs): update dark box variant inactive tab background color * chore(tabs): add changeset * fix(tabs): implement `--rh-color-icon-status-disabled` token * fix(tabs): update rh-color-icon-status-disabled light scheme value * fix(button): dark color scheme color and background color changes (#2598) * fix(button): add dark scheme support for primary variant * fix(button): update background color of danger primary variant * fix(button): update danger secondary color and border colors * fix(button): icon links only appear on the left * fix(button): update close button color tokens * fix(button): add disabled status tokens to disabled button variant * fix(button): update play icon color on dark color schemes * chore(button): add changeset * fix(button): update tokens for `color-status-disabled` and `color-text-status-disabled` * fix(audio-player): use container queries (#2575) * feat(audio-player): convert media queries to container queries * chore(audio-player): add changeset --------- Co-authored-by: Steven Spriggs <steven.spriggs@gmail.com> * fix(accordion): fix axe error regarding `aria-level` (#2625) * fix(accordion): fix axe error regarding `aria-level` * chore(accordion): add changeset * fix(accordion): check if `ariaLevel` is not yet set in the internalsController * fix(site-status): light scheme background colors (#2565) * feat(site-status): update light scheme background colors * fix(site-status): reduce time to go from loading to error/danger on critical status demo * chore(site-status): add changeset * docs(site-status): overview content updates * docs(site-status): content updates to the Style page * docs(site-status): update content on the Guidelines page * docs(site-status): update content and imagery on Accessibility page --------- Co-authored-by: Steven Spriggs <steven.spriggs@gmail.com> * feat(disclosure): add `borderless` and `compact` variants (#2631) * feat(disclosure): add open variant * feat(disclosure): add compact variant * fix(disclosure): update lightdom styles for `open` and `compact` variants * chore(disclosure): add changeset * fix(disclosure): design tweaks to the compact variant * fix(disclosure): design tweaks to the open disclosure variant * refactor(disclosure): use private vars for shared hover/focus/background colors. * refactor(disclosure): rename `variant="open"` to `variant="borderless"` * refactor(disclosure): lightdom shim `open` to `borderless` * fix(disclosure): round all the corners * chore(disclosure): changeset update about rounded borders * chore(disclosure): update variant name in changeset * fix(card): flex container parent support (#2583) * fix(card): correct layout when in parent flex box * chore(card): add changeset * docs(demos): remove duplicate `<main>` tags (#2642) * docs: fix bout typo on rh-icon guidelines (#2645) --------- Co-authored-by: Adam Johnson <adjohnso@redhat.com> Co-authored-by: Mark Caron <markcaron@users.noreply.github.com> * fix(jump-links): prevent column overflow / let text wrap to a new line (#2580) * fix(jump-links): let text wrap instead of overflowing adjacent column * chore(jump-links): add changeset * chore(jump-links): changeset wording Co-authored-by: Steven Spriggs <steven.spriggs@gmail.com> --------- Co-authored-by: Steven Spriggs <steven.spriggs@gmail.com> * fix(subnav): overflow regression (#2662) * fix(subnav): remove slotcontroller * chore(subnav): add changeset * fix(footer): reduce CLS before component upgrades or if JavaScript fails to load (#2560) * fix(footer): add no JS styles and vastly reduce CLS * chore(footer): add changeset * style(footer): lint CSS * fix(footer): remove fade in animation originally written to reduce CLS * fix(footer): increase gap for no JS links * fix(footer): side padding at various breakpoints for no js / not defined * chore: patch dev server lightdom * fix(footer): improve CLS in lightdom for grid and universal * fix(footer): wrap footer universal links and add appropriate space * fix(footer): make sure footer universal is placed in last grid row >992px * fix(footer): remove min-height on footer hosts This var should be removed at the next major release. * style(footer): lint lightdom css * fix(footer): touch up styling when JS disabled but template is DSD'ed * chore(footer): remove patch related to lightdom --------- Co-authored-by: Steven Spriggs <steven.spriggs@gmail.com> * docs: updating disclosure docs and images (#2661) * docs: updating disclosure docs and images * docs: adding alt text, removed commented out uxdot-example, fixed accessibility page SVGs * docs: disclosure image updates * docs: couple more image updates * feat: fixing keyboard interactions image * docs(disclosure): update image for keyboard interactions --------- Co-authored-by: marionnegp <mapatel@redhat.com> * feat(cta): add `text-*` CSS APIs (#2659) * feat(cta): add CSS APIs for `text-decoration` and `text-underline-offset` * chore(cta): add changeset * docs(cta): add desaturated CTA pattern (#2587) * docs(cta): add desaturated CTA pattern * docs(cta): format desaturated pattern * docs(cta): update desaturated pattern styles * docs(cta): desaturated secondary CTAs have their own unique styling * docs(cta): update style docs imagery * docs(cta): update Guidelines docs and imagery * docs(cta): update a11y page imagery * docs(cta): restore text on Style page * docs(cta): desaturated cta for podcast theme * docs: add summary column for tokens in element pages (#2667) * docs(tokens): remove tokens search (#2641) * docs(tokens): remove tokens search * chore: add space to trigger netlify * chore: remove space to trigger netlify * perf(code-block): set content-visibility on code-blocks (#2666) * perf(code-block): set content-visibility on code-blocks * docs(code-block): perf reproduction * perf(code-block): lower pressure on main thread when loading * docs(code-block): html ent escapes * docs: workaround for njk/11ty choking on giant html partial * style: lint --------- Co-authored-by: Steven Spriggs <steven.spriggs@gmail.com> * chore: prepare release (#2669) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * docs(cta): Style page content tweaks * docs(cta): fix desaturated CTA image dimensions in pattern docs * docs(cta): ensure brick variant desaturated CTAs have a strong border color --------- Co-authored-by: Benny Powers - עם ישראל חי! <bennypowers@users.noreply.github.com> Co-authored-by: Benny Powers <web@bennypowers.com> Co-authored-by: coreyvickery <45767595+coreyvickery@users.noreply.github.com> Co-authored-by: Steven Spriggs <steven.spriggs@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * fix(navigation-primary): visibly hide details contents for cmd/ctrl + f (#2675) * fix(navigation-primary): visibily hide content from cmd+f unless dropdown/hamburger is open * chore(navigation-primary): add changeset * fix(progress-stepper): token css fallback missing (#2673) * fix(progress-stepper): add missing css fallback values * chore(progress-stepper): add changeset --------- Co-authored-by: Benny Powers - עם ישראל חי! <bennypowers@users.noreply.github.com> * fix(navigation-primary): hidden title, accessible-label (#2648) * fix(navigation-primary): add header and use aria-labelleby instead of aria-label * chore(navigation-primary): add changeset * docs(navigation-primary): improve docs around accessible-label * docs(navigation-primary): remove color-palette attr from demos * fix(navigation-primary): update default label, styles, header position * docs(navigation-primary): update slot docs * chore: revert last commit, wrong branch * fix(navigation-primary): hide `role=list` elements when slots are empty (#2646) * fix(navigation-primary): hide role list elmenets when slots are empty * chore(navigation-primary): add changeset * fix(navigation-primary): add event to slot controller init * docs(navigation-primary): update slot docs * docs(navigation-primary): slot documentation comments position * fix(navigation-primary): add hidden attribute display none * fix(navigation-primary): add important to hidden * fix!: update icons to v2 (#2676) * feat: update RH Icons version to 2.0 * chore: updating changeset * chore: updating changeset * chore: update node version (#2622) * bumped nvmrc to latest node version * fixed typo * attempting to find a version compatible with linux CI * chore: update to latest node version * chore: revert back to lower minor release, errors in validate * chore: potential race condition, ensure analyze is run on docs command * chore: attempt to set the node version directly in the toml and other enhancements * chore: revert last changes, no changes on netlify build errors --------- Co-authored-by: Steven Spriggs <steven.spriggs@gmail.com> Co-authored-by: Benny Powers - עם ישראל חי! <bennypowers@users.noreply.github.com> * feat: add `<rh-navigation-link>` (#2624) * feat: add rh-navigation-link * fix(navigation-primary): add navigation-link support * fix(navigation-secondary): add navigation-link support * fix(subnav): add navigation-link support * test(navigation-link): clean up * fix(navigation-link): add alias decorator * fix(navigation-link): disable eslint on internals doesnt need reused * test(navigation-link): stub tests * test(audio-player): skip failing audio-player tests until we can fix * docs(navigation-link): improve component documentation * docs(navigation-link): missing ! in comments * chore(navigation-primary): remove orphaned code * fix(navigation-primary): correct tabbing through hamburger items, add navigation-link * fix(navgation-primary): styles for navigation-link * test(audio-player): revert skipped tests * fix(navigation-link): reverse logic for icon * test(navigation-vertical): skip test not supported by internals * test(navigation-link): update tests * docs(navigation-link): hard link lightdom.css * test(navigation-link): clean up test * docs(navigation-link): improve icon slot usage docs * fix(subnav): gap for rh-navigation-link with icon * docs(navigation-link): use all navigation links * docs: add rh-navigation-link to SSR config * docs(navigation-link): update readme * chore(navigation-link): add changeset * chore: add changesets for primary, secondary, and subnav * chore: update changesets * docs(naviation-link): add basic when to use to overview * docs(navigation-link): incorrect icon name * test(navigation-link): chai-ally-axe ignore rules that dont pass due to element internals * fix(navigation-link): add ability to change a links background color * fix(pagination): input on change, aria-current functionality (#2636) * fix(pagination): correct input onchange, also use type number * fix(pagination): set currentLink on connectedCallback * test(pagination): correct pagination, timing issue * docs(pagination): query params * docs(pagination): move notes to demo description in an alert * docs(pagination): initial attempt at vue demo * docs(pagination): remove old comment from vue demo * docs(pagination): remove another old comment from vue demo * docs(pagination): skip no-undef for external vue * docs(pagination): add comment to lightdom style tag in vue demo for why it exists * docs(pagination): 11ty safe vue demo * docs(pagination): remove wc comment in vue demo * docs(pagination): remove unused ref usage in vue demo * docs(pagination): improve vue demo * docs(pagination): fix output vue demo * docs(pagination): remove style tag, lightdom fixed in dev * docs(pagination): load vue from importmap * docs(pagination): add demo description for vue * docs(pagination): remove vue from devDeps, add a static cdn link in manualimportmaps * chore: ignore vue in importmap plugin for dev server * chore: reset package-lock * chore(pagination): add changeset * docs(pagination): improve implementation guidelines * docs(pagination): remove suggestion of dont change * docs(pagination): must have href --------- Co-authored-by: Mark Caron <markcaron@users.noreply.github.com> Co-authored-by: Benny Powers - עם ישראל חי! <bennypowers@users.noreply.github.com> * fix(tile): allow any color-palette and add demo page (#2613) * feat(color-palettes): add demo page Fixes #2467 * fix(tile): allow all color palettes and add demo page * fix(tile): correct CSS for color-palette rules * fix(tile): correct CSS for color-palette rules * Refactor color-palette selectors using prefix attribute selector * chore(changeset): bump @rhds/elements to minor * fix(rh-tile): correct color palette demos and update changeset formatting * ci: retrigger PR checks after clean * fix(tile): allow tile to accept all six color palettes --------- Co-authored-by: Benny Powers - עם ישראל חי! <bennypowers@users.noreply.github.com> * fix(subnav): improve accessibility with nested list when `<rh-navigation-link>` is slotted (#2683) * feat: add rh-navigation-link * fix(navigation-primary): add navigation-link support * fix(navigation-secondary): add navigation-link support * fix(subnav): add navigation-link support * test(navigation-link): clean up * fix(navigation-link): add alias decorator * fix(navigation-link): disable eslint on internals doesnt need reused * test(navigation-link): stub tests * test(audio-player): skip failing audio-player tests until we can fix * docs(navigation-link): improve component documentation * docs(navigation-link): missing ! in comments * chore(navigation-primary): remove orphaned code * fix(navigation-primary): correct tabbing through hamburger items, add navigation-link * fix(navgation-primary): styles for navigation-link * test(audio-player): revert skipped tests * fix(navigation-link): reverse logic for icon * test(navigation-vertical): skip test not supported by internals * test(navigation-link): update tests * docs(navigation-link): hard link lightdom.css * test(navigation-link): clean up test * docs(navigation-link): improve icon slot usage docs * fix(subnav): gap for rh-navigation-link with icon * docs(navigation-link): use all navigation links * fix(subnav): update subnav to accept only rh-navigation-link * docs(subnav): update demos to use rh-navigation-link * docs: update subnav usage on uxdot * docs: use current-page attribute on rh-navigation-link * fix(subnav): correct shim background-color * docs: add rh-navigation-link to SSR config * fix(subnav): design guidance, remove background, fix bottom border * docs: remove rh-subnav override style * docs(navigation-link): update readme * chore(navigation-link): add changeset * chore: add changesets for primary, secondary, and subnav * fix(subnav): revert change in naming for attributes * docs(subnav): add label attrs to overflow scroll demo * chore(subnav): add changeset * fix(subnav): correct default values of scroll attributes * chore: update changesets * docs(naviation-link): add basic when to use to overview * docs(navigation-link): incorrect icon name * test(navigation-link): chai-ally-axe ignore rules that dont pass due to element internals * fix(navigation-link): add ability to change a links background color * fix(subnav): add backwards compat * docs(subnav): revert demos back to slotted ahref, add nav link demo * chore(subnav): modify changeset to a minor * chore(subnav): add patch changeset for correcting color-scheme implmentation * fix(subnav): correct and deprecate color-palette attribute * chore(subnav): update changeset with deprecation * chore(subnav): add deprecated notice * fix(subnav): lint, bad merge * fix(subnav): combine lightdom files * fix(subnav): lint * fix(subnav): move part back on slot * fix(subnav): use aria-current instead of active * fix(subnav): use aria-current instead of active * fix(subnav): handle aria-current replacing active * fix(subnav): correctly handle overflow * chore(subnav): add changeset surrounding `active`/`aria-current` * chore(subnav): update changeset language around `aria-current` / `active` --------- Co-authored-by: Adam Johnson <adam.b.johnson1@gmail.com> * docs(navigation-link): add coming soon to docs (#2696) docs(navigation-link): add coming soon * docs(navigation-link): remove persistent alert, update element description (#2698) * docs(navigation-link): remove persistant from alert * docs(navigation-link): update element description * docs(navigation-link): add alert for default demo * Update elements/rh-navigation-link/demo/index.md --------- Co-authored-by: Mark Caron <markcaron@users.noreply.github.com> * feat(menu-dropdown): rh-menu-dropdown element (#2626) * chore: created rh-menu-dropdown component * chore: rh-menu-dropdown component created * chore: rh-menu-dropdown component created * chore: menu selection event updated * chore: dropdown style updated * fix: resolved outline issues * chore: added rh-menu * chore: added inert attribute for <hr/> tags * chore: variant examples added * fix: lint errors * chore: style updated * chore: implemented `close dropdown on outside click` functionality * chore: popover positioning added * chore: compact variant added * chore: interaction states added for compact boxed and open variant * Chore: interaction states added for non-compact menu variant * chore: keyboard navigation updated * chore: icon slot added for menu item * fix: accessibility issues * chore: added dropdown item with icon and description variants * docs: updated data.yaml file * chore: added dropdown with headings variant * fix: code cleanup * fix: rh-menu role fix * docs: updated documentation * fix: keyboard navigation * docs(menu-dropdown): add alias to fix demo urls * chore: code clean up * fix: aria-posinset aria-setsize accessibility issue * fix: interaction state style fix * fix: focus jump issue * fix: lint error * chore: added light-dark theme support * fix: lint errors * chore: updated tokens * chore: added light-dark theme support * chore: added testcases * chore: added test cases * chore: added disabled variant * feat(menu-dropdown): draft PR for POC (#2650) * chore: moved <rh-menu-item> and <rh-menu-item-group> inside <rh-menu> * chore: code cleanup * fix: test cases * fix: rh-menu-item focus state style * chore: open variant renamed to borderless * chore: added changeset * chore: updated border radius token * Update elements/rh-menu-dropdown/rh-menu-dropdown.css Co-authored-by: Steven Spriggs <steven.spriggs@gmail.com> * Update elements/rh-menu-dropdown/rh-menu-dropdown.css Co-authored-by: Steven Spriggs <steven.spriggs@gmail.com> * fix: lint errors * Update elements/rh-menu-dropdown/rh-menu-dropdown.css Co-authored-by: Steven Spriggs <steven.spriggs@gmail.com> * Update elements/rh-menu-dropdown/rh-menu-dropdown.css Co-authored-by: Steven Spriggs <steven.spriggs@gmail.com> * Update elements/rh-menu-dropdown/rh-menu-dropdown.css Co-authored-by: Steven Spriggs <steven.spriggs@gmail.com> * chore: updated code comments * chore: updated Dropdown select event * chore: code cleanup * fix: accessibility issue * doc: added JSDoc * fix: removed fixed height * chore: toggle variant shrinks to fit its text demo added * fix: lint error * chore: added menuitem role to host rh-menu-item element * chore: code cleanup * fix(menu): menu role menubar when standalone * fix(menu-dropdown): internalize rh-menu * docs(menu-dropdown): update demos * fix(audio-player): add role to internal rh-menu * fix(menu-dropdown): remove console.log * test(menu-dropdown): update tests * chore(menu-dropdown): update changeset * docs(menu-dropdown): update readme * test(menu): update tests * chore: updated group heading element * fix: group heading accessibility issue resolved * fix: aria-disabled attribute set via InternalsController for RhMenuItem * chore: updated aria-haspopup value to "menu" * chore: code cleanup * chore: updated text decoration and interaction state for links * chore: external link attribute added * chore: implement link click handling * chore: label name changed to toggle label * fix: test cases * chore: added button type * chore: added accessible-label attribute for compact dropdown * Update elements/rh-menu-dropdown/docs/00-overview.md Co-authored-by: Adam Johnson <adjohnso@redhat.com> * chore: added accessible name for info icon demo * Update .changeset/social-lizards-stop.md Co-authored-by: Adam Johnson <adjohnso@redhat.com> * Update elements/rh-menu-dropdown/docs/00-overview.md Co-authored-by: Adam Johnson <adjohnso@redhat.com> * Update elements/rh-menu-dropdown/docs/data.yaml Co-authored-by: Adam Johnson <adjohnso@redhat.com> * Update elements/rh-menu-dropdown/rh-menu-dropdown.ts Co-authored-by: Adam Johnson <adjohnso@redhat.com> * chore: color-context demo added * chore: added icon spacing * docs: overview * fix: test error * docs: updating demo names and separating out menu-item links * docs: adding Style documentation and images * Update elements/rh-menu-dropdown/rh-menu-dropdown.ts Co-authored-by: Benny Powers - עם ישראל חי! <bennypowers@users.noreply.github.com> * Update elements/rh-menu-dropdown/rh-menu-dropdown.ts Co-authored-by: Benny Powers - עם ישראל חי! <bennypowers@users.noreply.github.com> * chore: added classmap * Update elements/rh-menu-dropdown/rh-menu-dropdown.ts Co-authored-by: Benny Powers - עם ישראל חי! <bennypowers@users.noreply.github.com> * Update elements/rh-menu/rh-menu-item-group.css Co-authored-by: Benny Powers - עם ישראל חי! <bennypowers@users.noreply.github.com> * Update elements/rh-menu/rh-menu-item-group.ts Co-authored-by: Benny Powers - עם ישראל חי! <bennypowers@users.noreply.github.com> * chore: code cleanup * chore: updated class to id * fix: lint errors * docs: adding Guidelines and Accessibility docs and images * Update .changeset/social-lizards-stop.md Co-authored-by: Adam Johnson <adjohnso@redhat.com> * Update elements/rh-menu-dropdown/README.md Co-authored-by: Adam Johnson <adjohnso@redhat.com> * Update elements/rh-menu-dropdown/demo/basic-toggle-with-anchor-links.md Co-authored-by: Adam Johnson <adjohnso@redhat.com> * chore: added ssr check on slot change * docs: fixing tab spacing * Update elements/rh-menu-dropdown/rh-menu-dropdown.ts Co-authored-by: Adam Johnson <adjohnso@redhat.com> * chore: FloatingDOMController API added * docs: updated readme * fix: menu positioning * test(menu): ignore rule for aria-allowed role * docs: updated screenshot.png * chore: updated baclground surface token values. * chore: code cleanup * Update elements/rh-menu-dropdown/rh-menu-dropdown.ts Co-authored-by: Steven Spriggs <steven.spriggs@gmail.com> * Update elements/rh-menu-dropdown/rh-menu-dropdown.ts Co-authored-by: Steven Spriggs <steven.spriggs@gmail.com> * chore: on focus out test cases added for rh-menu * chore: code cleanup * chore: updated elevent config * fix: SSR error --------- Co-authored-by: Steven Spriggs <steven.spriggs@gmail.com> Co-authored-by: Adam Johnson <adjohnso@redhat.com> Co-authored-by: Mark Caron <mark.caron@gmail.com> Co-authored-by: Mark Caron <markcaron@users.noreply.github.com> Co-authored-by: Benny Powers - עם ישראל חי! <bennypowers@users.noreply.github.com> * feat(navigation-vertical): add `<rh-navigation-vertical>` (#2627) * feat: add rh-navigation-link * fix(navigation-primary): add navigation-link support * fix(navigation-secondary): add navigation-link support * fix(subnav): add navigation-link support * feat(navigation-veritcal): add `<rh-navigation-vertical>` * test(navigation-link): clean up * fix(navigation-link): add alias decorator * fix(navigation-link): disable eslint on internals doesnt need reused * test(navigation-link): stub tests * test(audio-player): skip failing audio-player tests until we can fix * tests(navigation-vertical): update to use new deps * fix(navigation-vertical): remove vertical item replace with nav-link * docs: integrate nav vertical in sidenav * docs: sidenav stable gutter * docs: undo last commit, wrong branch * docs(navigation-link): improve component documentation * docs(navigation-link): missing ! in comments * fix(navigation-veritcal): correctly label the navigation * docs(navigation-vertical): fix demo * fix(navigation-vertical): add aria-labelledby to host * test(navigation-vertical): skip host element internals role check * chore(navigation-primary): remove orphaned code * fix(navigation-primary): correct tabbing through hamburger items, add navigation-link * fix(navgation-primary): styles for navigation-link * test(audio-player): revert skipped tests * fix(navigation-link): reverse logic for icon * test(navigation-vertical): skip test not supported by internals * test(navigation-link): update tests * docs(navigation-link): hard link lightdom.css * test(navigation-link): clean up test * docs(navigation-link): improve icon slot usage docs * fix(subnav): gap for rh-navigation-link with icon * docs(navigation-link): use all navigation links * docs: add rh-navigation-link to SSR config * docs(navigation-link): update readme * chore(navigation-link): add changeset * chore: add changesets for primary, secondary, and subnav * docs(navigation-vertical): move slot docs * docs(navigation-vertical): correct readme * chore(navigation-vertical): add changeset * test(navigation-vertical): add explict role to nav link * chore: update changesets * docs(naviation-link): add basic when to use to overview * docs(navigation-link): incorrect icon name * test(navigation-link): chai-ally-axe ignore rules that dont pass due to element internals * docs(navigation-vertical): duplicate current-page attr * docs(navigation-vertical): correct readme * docs(navigation-vertical): alias decorators and cem doc comments * fix(navigation-link): add ability to change a links background color * fix(navigation-vertical): add lightdom.css for deeply nested * fix(navigation-vertical): background-color for nested current-page * chore(navigation-vertical): update changeset * fix(navigation-vertical): correct link background for color-scheme * fix(navigation-vertical): apply new design language * fix(subnav): missing current-page style * docs: correct vertical nav integration into uxdot-sidenav * fix(navigation-vertical): remove remaining bordered code * fix(navigation-vertical): add highlight attribute * docs(navigation-vertical): add highlight to nested demo * test(navigation-vertical): update tests * docs(navigation-vertical): add screenshot * docs(navigation-vertical): add coming soon * chore(navigation-vertical): update changeset * fix(navigation-vertical): correct gap * fix(navigation-vertical): correct spacing top of vertical list * fix(navigation-vertical): fix active state * fix(navigation-vertical): add rh-icon rotation back in * doc: refactor uxdot-sidenav * docs(navigation-vertical): remove persistant from alert * docs(navigation-vertical): renamed demo * docs: remove subnav-lightdom * docs(navigation-vertical): alias vertical to match primary and secondary navs * fix(navigation-vertical): include a gap for tight containers Co-authored-by: Mark Caron <markcaron@users.noreply.github.com> * fix(navigation-vertical): lint --------- Co-authored-by: Mark Caron <markcaron@users.noreply.github.com> * chore: update @rhds/tokens dep (#2700) chore: update @rhds/tokens --------- Co-authored-by: Adam Johnson <adjohnso@redhat.com> Co-authored-by: Mark Caron <markcaron@users.noreply.github.com> Co-authored-by: marionnegp <mapatel@redhat.com> Co-authored-by: Benny Powers - עם ישראל חי! <bennypowers@users.noreply.github.com> Co-authored-by: Benny Powers <web@bennypowers.com> Co-authored-by: coreyvickery <45767595+coreyvickery@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Daniel Faucette <danieljfaucette@gmail.com> Co-authored-by: Gili-Greenberger <g0583268792@gmail.com> Co-authored-by: Adam Johnson <adam.b.johnson1@gmail.com> Co-authored-by: Arathy Kumar <49025521+ArathyKumar@users.noreply.github.com> Co-authored-by: Mark Caron <mark.caron@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
<rh-navigation-link>automatically adds role="list" to container if a<rh-navigation-link>is slotted.<a href>implementation.color-paletteattribute. Design has stated subnav should be transparent and react to the parent color-scheme.Correctly splitMaintained the lightdom as a single file, we will need to make this as a breaking change later. fix!: lightdom shim styles should be in their own files, and not required. #2665lightdom.cssandlightdom-shim.cssstyles into their correct files.before
after with rh-navigation-link
Todo
Testing Instructions
Notes to Reviewers