-
Notifications
You must be signed in to change notification settings - Fork 188
ls parser speed improvements, reworked #4408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
PaulWay
wants to merge
18
commits into
master
Choose a base branch
from
paulway_ls_parser_speed_improvements
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Avoid re-splitting the line if it's already been split. - Handle a few failure modes in parsing links and size on '?' and other bad input. - Each directory is all one 'mode' - normal, or SELinux on RHEL 6/7 or 8+. Instead of trying to detect the mode of each line, detect the mode once and then use that for all lines in this directory. Difficult to extrapolate that to all listings in a parse - let's see how this goes for now. - Simplify how we pick up directory names and store previously processed directories. - Add a few comments to make it easier to see what's being parsed where. Signed-off-by: Paul Wayper <[email protected]>
Signed-off-by: Paul Wayper <[email protected]>
…owner, group, rest) Signed-off-by: Paul Wayper <[email protected]>
Signed-off-by: Paul Wayper <[email protected]>
Signed-off-by: Paul Wayper <[email protected]>
Signed-off-by: Paul Wayper <[email protected]>
… on dirent type Signed-off-by: Paul Wayper <[email protected]>
…linux check Signed-off-by: Paul Wayper <[email protected]>
…e switch on files first Signed-off-by: Paul Wayper <[email protected]>
Signed-off-by: Paul Wayper <[email protected]>
Signed-off-by: Paul Wayper <[email protected]>
Signed-off-by: Paul Wayper <[email protected]>
Signed-off-by: Paul Wayper <[email protected]>
Signed-off-by: Paul Wayper <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4408 +/- ##
==========================================
+ Coverage 77.50% 77.51% +0.01%
==========================================
Files 744 744
Lines 41574 41571 -3
Branches 6667 6665 -2
==========================================
+ Hits 32220 32223 +3
+ Misses 8319 8315 -4
+ Partials 1035 1033 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Pull Requests:
Check all that apply:
Complete Description of Additions/Changes:
This is an update for my previous ls parser speed improvements work, after the removal of 'raw_entry' by @xiangce.
Main speed improvements are:
Readability improvements are: