Skip to content

fix: improve wording for unassignable Policy #4414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: improve wording for unassignable Policy #4414

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion insights/specs/datasources/compliance/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,7 @@ def policy_link(self, policy_id, opt):
logger.info("Operation completed successfully.\n")
Copy link
Contributor

@Mishrasubha Mishrasubha Apr 3, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we also change Operation completed successfully to something more specific like System successfully assigned to policy?

return 0
else:
logger.error("Policy ID {0} does not exist.".format(policy_id))
logger.error("Policy ID {0} can not be assigned.".format(policy_id))
return constants.sig_kill_bad

def get_system_policies(self):
Expand Down
Loading