-
Notifications
You must be signed in to change notification settings - Fork 188
feat: new datasources: host_key_files #4415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: shlao <[email protected]>
84039fc
to
826251e
Compare
Signed-off-by: shlao <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not a good idea to read the /var/log/messages
directly in datasource as it would be huge.
If you have to do that, please use the existing spec, as it's filtered.
Finally, if the file on customer side is huge even after filtering, this datasource will be time/memory consuming.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4415 +/- ##
=======================================
Coverage 77.51% 77.51%
=======================================
Files 744 745 +1
Lines 41585 41610 +25
Branches 8832 8837 +5
=======================================
+ Hits 32233 32256 +23
- Misses 8318 8320 +2
Partials 1034 1034
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: shlao <[email protected]>
Signed-off-by: shlao <[email protected]>
Signed-off-by: shlao <[email protected]>
@shlao as mentioned, we need to reconsider if it's worth adding this spec to core collection, do you have a Jira card to get this spec being approved first? |
All Pull Requests:
Check all that apply:
Complete Description of Additions/Changes:
Add datasource to check why sshd couldn’t load host key.