Skip to content

feat: new datasources: host_key_files #4415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

shlao
Copy link
Contributor

@shlao shlao commented Apr 6, 2025

All Pull Requests:

Check all that apply:

  • Have you followed the guidelines in our Contributing document, including the instructions about commit messages?
  • No Sensitive Data in this change?
  • Is this PR to correct an issue?
  • Is this PR an enhancement?

Complete Description of Additions/Changes:

Add datasource to check why sshd couldn’t load host key.

@shlao shlao force-pushed the host_das_key branch 2 times, most recently from 84039fc to 826251e Compare April 6, 2025 14:28
Copy link
Contributor

@xiangce xiangce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not a good idea to read the /var/log/messages directly in datasource as it would be huge.
If you have to do that, please use the existing spec, as it's filtered.

Finally, if the file on customer side is huge even after filtering, this datasource will be time/memory consuming.

@codecov-commenter
Copy link

codecov-commenter commented Apr 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.51%. Comparing base (77360f5) to head (156950e).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4415   +/-   ##
=======================================
  Coverage   77.51%   77.51%           
=======================================
  Files         744      745    +1     
  Lines       41585    41610   +25     
  Branches     8832     8837    +5     
=======================================
+ Hits        32233    32256   +23     
- Misses       8318     8320    +2     
  Partials     1034     1034           
Flag Coverage Δ
unittests 77.50% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: shlao <[email protected]>
@xiangce
Copy link
Contributor

xiangce commented Apr 8, 2025

@shlao as mentioned, we need to reconsider if it's worth adding this spec to core collection, do you have a Jira card to get this spec being approved first?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants