Skip to content

Conversation

@ryemorris
Copy link
Contributor

@ryemorris ryemorris commented Nov 18, 2025

Overview

This PR is being created to address HCMSEC-2397.

Removing versioning from SC share konflux pipeline URL, using latest pipeline version instead (main)

PR Checklist

  • Keep PR title short, ideally under 72 characters
  • Descriptive comments provided in complex code blocks
  • Include raw query examples in the PR description, if adding/modifying SQL query
  • Tests: validate optimal/expected output
  • Tests: validate exceptions and failure scenarios
  • Tests: edge cases
  • Recovers or fails gracefully during potential resource outages (e.g. DB, Kafka)
  • Uses type hinting, if convenient
  • Documentation, if this PR changes the way other services interact with host inventory
  • Links to related PRs

Secure Coding Practices Documentation Reference

You can find documentation on this checklist here.

Secure Coding Checklist

  • Input Validation
  • Output Encoding
  • Authentication and Password Management
  • Session Management
  • Access Control
  • Cryptographic Practices
  • Error Handling and Logging
  • Data Protection
  • Communication Security
  • System Configuration
  • Database Security
  • File Management
  • Memory Management
  • General Coding Practices

Summary by Sourcery

CI:

  • Update Tekton pipeline URLs to reference raw/main instead of v1.45.0

@ryemorris ryemorris requested a review from a team as a code owner November 18, 2025 19:52
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Nov 18, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updated Tekton pipeline annotations in the security-compliance workflows to point to the main branch of konflux-pipelines instead of a fixed version tag.

File-Level Changes

Change Details Files
Use main branch for konflux-pipelines in pipeline annotations
  • Replaced versioned raw URL in the pull-request pipeline annotation
  • Replaced versioned raw URL in the push pipeline annotation
.tekton/insights-host-inventory-sc-pull-request.yaml
.tekton/insights-host-inventory-sc-push.yaml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@ezr-ondrej
Copy link
Member

Thank you @ryemorris ! 🙏 What is the background behind the change? It's not a big deal for me, but the reliance on tag was thought to be safer and should be updated automatically by Mintmaker, so not a big deal on active repository.

If you still need this, happy to merge ofc :)

@ryemorris
Copy link
Contributor Author

Hi @ezr-ondrej! Thanks for checking in. I agree the image tag would be safer but they move so fast that we always seem to be out of date whenever its time to deploy new images in our cycle. We turned off mintmaker for the SC branch because we just checkout a hash from master and end up overwriting the changes anyway. We may run into an issue with the latest not working but I feel we are less likely that than our pipelines being out of date in the future

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants