-
Notifications
You must be signed in to change notification settings - Fork 92
Remove versioning from konflux-pipelines URL, use main branch (#3175) #3178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Remove versioning from konflux-pipelines URL, use main branch (#3175) #3178
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdated Tekton pipeline annotations in the security-compliance workflows to point to the main branch of konflux-pipelines instead of a fixed version tag. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
Thank you @ryemorris ! 🙏 What is the background behind the change? It's not a big deal for me, but the reliance on tag was thought to be safer and should be updated automatically by Mintmaker, so not a big deal on active repository. If you still need this, happy to merge ofc :) |
|
Hi @ezr-ondrej! Thanks for checking in. I agree the image tag would be safer but they move so fast that we always seem to be out of date whenever its time to deploy new images in our cycle. We turned off mintmaker for the SC branch because we just checkout a hash from master and end up overwriting the changes anyway. We may run into an issue with the latest not working but I feel we are less likely that than our pipelines being out of date in the future |
Overview
This PR is being created to address HCMSEC-2397.
Removing versioning from SC share konflux pipeline URL, using latest pipeline version instead (main)
PR Checklist
Secure Coding Practices Documentation Reference
You can find documentation on this checklist here.
Secure Coding Checklist
Summary by Sourcery
CI: