Drop legacy building #371
Draft
Drop legacy building #371
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The conditions repo has updated its building process and we need adapt this repo. The changes include - add golang to the build step for the conditions as there is a Go tool run as part of the process. While we can have provided its binary, as we are building 2 version at the same time, the might be differences in the tool, so to account for that we are compiling the binary at runtime. - the new build script is in Python, so we need Python in the build image. Also we are fixing the Python version to 3.11 and creating a venv for it following the instructions provided by the gathering conditions repo. - create 2 bash functions one for the new build setup and one for the legacy one
Now that a new build script has been implemented in the gathering conditions repo and it is being used for all versions, we can remove the old code related to the legacy building system.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Now that a new build script has been implemented in the gathering conditions repo
and it is being used for all versions, we can remove the old code related to the legacy building system.
Type of change
Testing steps
Checklist
make before_commitpasses