Skip to content

RHINENG-24606: Remove npm dependency#1006

Open
marleystipich2 wants to merge 1 commit intomasterfrom
remove-npm-dependency
Open

RHINENG-24606: Remove npm dependency#1006
marleystipich2 wants to merge 1 commit intomasterfrom
remove-npm-dependency

Conversation

@marleystipich2
Copy link
Collaborator

@marleystipich2 marleystipich2 commented Mar 5, 2026

Summary by Sourcery

Build:

  • Remove the npm package from runtime dependencies in package.json to rely on the environment-provided npm tooling instead.

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Mar 5, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Removes the direct dependency on the npm package and updates the lockfile accordingly to reflect the dependency graph without it.

Flow diagram for dependency graph change removing npm package

flowchart LR
    subgraph Before
        A[project] --> B[jszip]
        A --> C[lodash]
        A --> D[mustache]
        A --> E[npm]
        A --> F[openapi_default_setter]
        A --> G[openapi_request_coercer]
        A --> H[openapi_request_validator]
    end

    subgraph After
        A2[project] --> B2[jszip]
        A2 --> C2[lodash]
        A2 --> D2[mustache]
        A2 --> F2[openapi_default_setter]
        A2 --> G2[openapi_request_coercer]
        A2 --> H2[openapi_request_validator]
    end

    E -. removed .- A2
Loading

File-Level Changes

Change Details Files
Remove the npm package from runtime dependencies and sync the lockfile.
  • Deleted the npm entry from the dependencies list so it is no longer installed as an application dependency.
  • Regenerated or updated package-lock.json to reflect the removal of npm from the dependency tree.
package.json
package-lock.json

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • The npm dependency was removed from package.json but package-lock.json doesn’t show corresponding updates in the diff—please regenerate the lockfile so it’s consistent with the updated dependencies.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- The npm dependency was removed from package.json but package-lock.json doesn’t show corresponding updates in the diff—please regenerate the lockfile so it’s consistent with the updated dependencies.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant