RHINENG-14116 fix README.md build status#964
Open
pfreyburg wants to merge 2 commits intoRedHatInsights:masterfrom
Open
RHINENG-14116 fix README.md build status#964pfreyburg wants to merge 2 commits intoRedHatInsights:masterfrom
pfreyburg wants to merge 2 commits intoRedHatInsights:masterfrom
Conversation
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates README documentation to reflect current build and release processes by removing legacy Jenkins references and describing the Konflux/App-SRE pipeline. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
3db8802 to
25890a4
Compare
Contributor
There was a problem hiding this comment.
Hey - I've found 1 issue, and left some high level feedback:
- There’s a small grammatical issue in the new sentence: change “The image is build using Konflux and it is released using using App-sre.” to something like “The image is built using Konflux and released using AppSRE.” (fixing “build” → “built”, removing the duplicate “using”, and normalizing “App-sre” if appropriate).
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- There’s a small grammatical issue in the new sentence: change “The image is build using Konflux and it is released using using App-sre.” to something like “The image is built using Konflux and released using AppSRE.” (fixing “build” → “built”, removing the duplicate “using”, and normalizing “App-sre” if appropriate).
## Individual Comments
### Comment 1
<location> `README.md:102` </location>
<code_context>
This process is controlled by the [deployment Jenkinsfile](./deployment/Jenkinsfile).
-The image can then be promoted to production using a [Jenkins job](https://jenkins-insights-jenkins.1b13.insights.openshiftapps.com/job/remediations/job/remediations-release/). Use the git commit SHA as the REVISION when running the job.
+The image is build using Konflux and it is released using using App-sre.
## Contact
</code_context>
<issue_to_address>
**issue (typo):** Fix verb form, duplicated word, and verify capitalization in this sentence.
Change "is build" to "is built," remove the duplicated "using," and confirm the correct capitalization for "App-sre" (e.g., "AppSRE" or your usual convention).
```suggestion
The image is built using Konflux and is released using AppSRE.
```
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Update project README to reflect current build and release process.
Documentation: