Skip to content

RHCLOUD-24319: Build out openshift learning resources #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 1, 2023
Merged

RHCLOUD-24319: Build out openshift learning resources #114

merged 4 commits into from
Jun 1, 2023

Conversation

florkbr
Copy link
Contributor

@florkbr florkbr commented May 31, 2023

@app-sre-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@florkbr
Copy link
Contributor Author

florkbr commented May 31, 2023

@maryshak1996 FYI I see you've opened #103 to cover openshift-deploy-rsa. I've included it in my PR here since that PR is failing. Let me know if you have any concerns!

@florkbr
Copy link
Contributor Author

florkbr commented May 31, 2023

/ok-to-test

@florkbr
Copy link
Contributor Author

florkbr commented Jun 1, 2023

@Hyperkid123 would you mind having a look? Thanks in advance!

@Hyperkid123
Copy link
Collaborator

/ok-to-test

Hyperkid123
Hyperkid123 reviewed Jun 1, 2023
View reviewed changes
Copy link
Collaborator

@Hyperkid123 Hyperkid123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK other than the bundle strings

docs/quickstarts/openshift-cost-explorer/metadata.yml Outdated
name: openshift-cost-explorer
tags: # If you want to use more granular filtering add tags to the quickstart
- kind: bundle
value: OpenShift
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be lowercase (unless the router does not care and it works anyways)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Hyperkid123 done. I was using the bundle that was already present in this repo for openshift-related-documentation (so I guess it would have worked?).

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I honestly don't know. The learning resources UI is configured to use the openshift value for the Opensihft page.

docs/quickstarts/openshift-cost-management-access/metadata.yml Outdated
name: openshift-cost-management-access
tags: # If you want to use more granular filtering add tags to the quickstart
- kind: bundle
value: OpenShift
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^^

@Hyperkid123 Hyperkid123 merged commit 224d76b into RedHatInsights:main Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hyperkid123 Hyperkid123 Hyperkid123 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@florkbr @app-sre-bot @Hyperkid123