modified pr checks #733
Merged
modified pr checks #733
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's GuideThis PR refactors deployment configs by removing legacy KESSEL environment variables in favor of a unified BACKEND_VERSION parameter across all services, and enhances the PR check script to dynamically select IQE test markers and CI metadata based on the backend version. Flow diagram for backend version selection in PR check scriptflowchart TD
Start(["Start PR check script"]) --> GetVersion["Read BACKEND_VERSION (default: 'old')"]
GetVersion --> Decision{Is BACKEND_VERSION 'old', 'new', or other?}
Decision -->|old| OldVars["Set IQE_MARKER_EXPRESSION='ros_smoke and (common or old_backend)'\nSet IBUTSU_SOURCE='ros-old-backend-pr'"]
Decision -->|new| NewVars["Set IQE_MARKER_EXPRESSION='ros_smoke and (common or new_backend)'\nSet IBUTSU_SOURCE='ros-new-backend-pr'"]
Decision -->|other| DefaultVars["Set IQE_MARKER_EXPRESSION='ros_smoke'\nSet IBUTSU_SOURCE='ros-backend-pr'"]
OldVars --> End(["Continue CI/CD pipeline"])
NewVars --> End
DefaultVars --> End
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
upadhyeammit
requested changes
Nov 18, 2025
Contributor
upadhyeammit
left a comment
upadhyeammit
left a comment
There was a problem hiding this comment.
At the same time, are we also wanting to handle a trigger for both pipelines? or we can just use two triggers and that should be good as well
pr_check.sh
Outdated
| # NEW: Dual backend testing logic based on job name | ||
| echo "JOB_NAME: $JOB_NAME" | ||
|
|
||
| if [[ "$JOB_NAME" == *"old-backend"* ]]; then |
Contributor
There was a problem hiding this comment.
This will need change based on ros-backend-v1-pr-tests
pr_check.sh
Outdated
|
|
||
| if [[ "$JOB_NAME" == *"old-backend"* ]]; then | ||
| # Old backend testing configuration | ||
| export ROS_NEW_BACKEND_FLAG_ENABLED="false" |
Contributor
There was a problem hiding this comment.
which flag is this? and where its getting used?
Contributor
Author
There was a problem hiding this comment.
https://gitlab.cee.redhat.com/insights-qe/iqe-ros-plugin/-/merge_requests/413
This flag is used in iqe.
Can you please check this pr.
pr_check.sh
Outdated
| # Old backend testing configuration | ||
| export ROS_NEW_BACKEND_FLAG_ENABLED="false" | ||
| export IQE_MARKER_EXPRESSION="ros_smoke and (common or old_backend)" | ||
| export IBUTSU_SOURCE="ros-old-backend-pr" |
Contributor
There was a problem hiding this comment.
is it possible to make this in sync with name ros-backend-v1-pr-tests
pr_check.sh
Outdated
| echo " Configured for OLD backend testing" | ||
| echo " - Unleash flag will be set to: FALSE" | ||
| echo " - Test markers: ros_smoke and (common or old_backend)" | ||
| elif [[ "$JOB_NAME" == *"new-backend"* ]]; then |
Contributor
There was a problem hiding this comment.
Make this in sync with ros-backend-v2-pr-tests
pr_check.sh
Outdated
| echo " - Test markers: ros_smoke and (common or old_backend)" | ||
| elif [[ "$JOB_NAME" == *"new-backend"* ]]; then | ||
| # New backend testing configuration | ||
| export ROS_NEW_BACKEND_FLAG_ENABLED="true" |
Contributor
There was a problem hiding this comment.
same, where this is getting used?
pr_check.sh
Outdated
| # New backend testing configuration | ||
| export ROS_NEW_BACKEND_FLAG_ENABLED="true" | ||
| export IQE_MARKER_EXPRESSION="ros_smoke and (common or new_backend)" | ||
| export IBUTSU_SOURCE="ros-new-backend-pr" |
Contributor
There was a problem hiding this comment.
if it can align with ros-backend-v2-pr-tests then it will be nice
Contributor
|
/retest |
Contributor
|
test-v1 |
Contributor
Author
|
/retest test-v1 |
upadhyeammit
approved these changes
Nov 21, 2025
added 8 commits
November 21, 2025 19:18
This reverts commit 7ee6d49.
upadhyeammit
force-pushed
the
spimpalg-ros-dual-backend-testing
branch
from
688665c to
ead0834
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Title 💥
Please title this PR with a summary of the change, along with the JIRA card number.
Suggested formats:
Feel free to remove this section from PR description once done.
Why do we need this change? 💭
Please include the context of this change here.
Documentation update? 📝
Security Checklist 🔒
Upon raising this PR please go through RedHatInsights/secure-coding-checklist
💂♂️ Checklist 🎯
Additional 📣
Feel free to add any other relevant details such as links, notes, screenshots, here.
Summary by Sourcery
Allow dynamic selection of backend version by replacing KESSEL flags with a unified BACKEND_VERSION parameter and adapting pull request checks and deployment arguments accordingly
New Features:
Enhancements:
CI: