Potential fix for code scanning alert no. 6: Workflow does not contain permissions#339
Open
jirihnidek wants to merge 1 commit intomainfrom
Open
Potential fix for code scanning alert no. 6: Workflow does not contain permissions#339jirihnidek wants to merge 1 commit intomainfrom
jirihnidek wants to merge 1 commit intomainfrom
Conversation
Reviewer's GuideIntroduces a root‐level permissions block in the update-version workflow to grant only the minimal GitHub token scopes (contents: write, pull-requests: write) required by the job, satisfying the code scanning alert. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
* Workflow `update-version.yml` does not contain permissions Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
119f1fa to
16b66a2
Compare
There was a problem hiding this comment.
Hey @jirihnidek - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/RedHatInsights/yggdrasil/security/code-scanning/6
To fix the issue, we need to add a
permissionsblock to the workflow. This block should specify the minimal permissions required for the workflow to function correctly. Based on the operations performed in the workflow, the following permissions are necessary:contents: writefor pushing changes to the repository.pull-requests: writefor creating pull requests.The
permissionsblock can be added at the root level of the workflow to apply to all jobs, or it can be added specifically to theupdate-versionjob. In this case, adding it at the root level is sufficient and ensures consistency.Suggested fixes powered by Copilot Autofix. Review carefully before merging.
Summary by Sourcery
Bug Fixes:
permissionsblock withcontents: writeandpull-requests: writeto the update-version workflow