Skip to content

Potential fix for code scanning alert no. 6: Workflow does not contain permissions#339

Open
jirihnidek wants to merge 1 commit intomainfrom
alert-autofix-6
Open

Potential fix for code scanning alert no. 6: Workflow does not contain permissions#339
jirihnidek wants to merge 1 commit intomainfrom
alert-autofix-6

Conversation

@jirihnidek
Copy link
Contributor

@jirihnidek jirihnidek commented Jun 4, 2025

Potential fix for https://github.com/RedHatInsights/yggdrasil/security/code-scanning/6

To fix the issue, we need to add a permissions block to the workflow. This block should specify the minimal permissions required for the workflow to function correctly. Based on the operations performed in the workflow, the following permissions are necessary:

  • contents: write for pushing changes to the repository.
  • pull-requests: write for creating pull requests.

The permissions block can be added at the root level of the workflow to apply to all jobs, or it can be added specifically to the update-version job. In this case, adding it at the root level is sufficient and ensures consistency.

Suggested fixes powered by Copilot Autofix. Review carefully before merging.

Summary by Sourcery

Bug Fixes:

  • Add a root-level permissions block with contents: write and pull-requests: write to the update-version workflow

@sourcery-ai
Copy link

sourcery-ai bot commented Jun 4, 2025

Reviewer's Guide

Introduces a root‐level permissions block in the update-version workflow to grant only the minimal GitHub token scopes (contents: write, pull-requests: write) required by the job, satisfying the code scanning alert.

File-Level Changes

Change Details Files
Add root-level permissions block
  • Insert top-level permissions: key
  • Set contents: write
  • Set pull-requests: write
.github/workflows/update-version.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

* Workflow `update-version.yml` does not contain permissions

Co-authored-by: Copilot Autofix powered by AI
<62310815+github-advanced-security[bot]@users.noreply.github.com>
@jirihnidek jirihnidek marked this pull request as ready for review June 4, 2025 18:21
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jirihnidek - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant