Potential fix for code scanning alert no. 4: Workflow does not contain permissions#340
Open
jirihnidek wants to merge 1 commit intomainfrom
Open
Potential fix for code scanning alert no. 4: Workflow does not contain permissions#340jirihnidek wants to merge 1 commit intomainfrom
jirihnidek wants to merge 1 commit intomainfrom
Conversation
Reviewer's GuideAdds an explicit permissions block to the release workflow, granting only the "contents: write" permission to satisfy security scanning requirements and minimize access. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
* Workflow `tag-release.yml` does not contain permissions Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
27e6423 to
12977ba
Compare
There was a problem hiding this comment.
Hey @jirihnidek - I've reviewed your changes and found some issues that need to be addressed.
Blocking issues:
- Granting write permissions on pull_request can be a security risk (link)
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Comment on lines
+3
to
+4
| permissions: | ||
| contents: write |
There was a problem hiding this comment.
🚨 issue (security): Granting write permissions on pull_request can be a security risk
Untrusted forked code could use the write-enabled GITHUB_TOKEN to create tags or releases. Use pull_request_target or stricter branch filters to mitigate this risk.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/RedHatInsights/yggdrasil/security/code-scanning/4
To fix the issue, we will add a
permissionsblock at the root of the workflow to explicitly define the minimal permissions required. Since the workflow creates a GitHub release, it needscontents: writepermissions. All other permissions will be omitted to minimize access. This change ensures that the workflow only has the permissions it needs to function correctly.Suggested fixes powered by Copilot Autofix. Review carefully before merging.
Summary by Sourcery
CI: