Skip to content

Potential fix for code scanning alert no. 4: Workflow does not contain permissions#340

Open
jirihnidek wants to merge 1 commit intomainfrom
alert-autofix-4
Open

Potential fix for code scanning alert no. 4: Workflow does not contain permissions#340
jirihnidek wants to merge 1 commit intomainfrom
alert-autofix-4

Conversation

@jirihnidek
Copy link
Contributor

@jirihnidek jirihnidek commented Jun 4, 2025

Potential fix for https://github.com/RedHatInsights/yggdrasil/security/code-scanning/4

To fix the issue, we will add a permissions block at the root of the workflow to explicitly define the minimal permissions required. Since the workflow creates a GitHub release, it needs contents: write permissions. All other permissions will be omitted to minimize access. This change ensures that the workflow only has the permissions it needs to function correctly.


Suggested fixes powered by Copilot Autofix. Review carefully before merging.

Summary by Sourcery

CI:

  • Grant only contents: write permission in .github/workflows/tag-release.yml

@sourcery-ai
Copy link

sourcery-ai bot commented Jun 4, 2025

Reviewer's Guide

Adds an explicit permissions block to the release workflow, granting only the "contents: write" permission to satisfy security scanning requirements and minimize access.

File-Level Changes

Change Details Files
Add minimal permissions to GitHub workflow
  • Inserted a permissions block at the top of the workflow
  • Configured only contents: write permission
  • Omitted all other permissions to enforce least privilege
.github/workflows/tag-release.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

* Workflow `tag-release.yml` does not contain permissions

Co-authored-by: Copilot Autofix powered by AI
<62310815+github-advanced-security[bot]@users.noreply.github.com>
@jirihnidek jirihnidek marked this pull request as ready for review June 4, 2025 18:21
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jirihnidek - I've reviewed your changes and found some issues that need to be addressed.

Blocking issues:

  • Granting write permissions on pull_request can be a security risk (link)
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Comment on lines +3 to +4
permissions:
contents: write
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚨 issue (security): Granting write permissions on pull_request can be a security risk

Untrusted forked code could use the write-enabled GITHUB_TOKEN to create tags or releases. Use pull_request_target or stricter branch filters to mitigate this risk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant