fix: resolve potential race condition by connecting transporter earlier#384
Open
fix: resolve potential race condition by connecting transporter earlier#384
Conversation
DuckBoss
force-pushed
the
jajerome/yggd-race-cond-tests
branch
from
3d55794 to
0a405d9
Compare
This patch aims to resolve issues sending initial messages published by the dispatcher by reordering the client connection steps to make the transporter connect to the broker before the dispatcher goroutine attempts to publish the initial connection status message. Resolves: CCT-2074 Signed-off-by: Jason Jerome <jajerome@redhat.com>
DuckBoss
force-pushed
the
jajerome/yggd-race-cond-tests
branch
from
0a405d9 to
719d702
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch aims to resolve issues sending initial messages published by the dispatcher by reordering the client connection steps to make the transporter connect to the broker before the dispatcher goroutine attempts to publish the initial connection status message.
Resolves: CCT-2074