Convert sync managers to proxy models #1167
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
None of the sync manager concrete models introduce any schema changes, instead the only difference in implementation is Python-based, this makes these models prime candidates for Proxy models, i.e. models that share the same table but differ in python implementation. The reasoning is so that it's easier to query and expose sync manager data through e.g. a single API endpoint instead of many endpoints or a very custom and complex endpoint. This commit also fixes a nasty but easy to miss bug WRT the relationship between sync managers and the respective entity that they sync: if a sync manager row was to be deleted, the related Flaw/Tracker would be deleted on cascade.
Elkasitu
added
the
technical
Jincxz
approved these changes
Dec 23, 2025
MrMarble
approved these changes
Dec 24, 2025
dmonzonis
approved these changes
Dec 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
None of the sync manager concrete models introduce any schema changes, instead the only difference in implementation is Python-based, this makes these models prime candidates for Proxy models, i.e. models that share the same table but differ in python implementation.
The reasoning is so that it's easier to query and expose sync manager data through e.g. a single API endpoint instead of many endpoints or a very custom and complex endpoint.
This commit also fixes a nasty but easy to miss bug WRT the relationship between sync managers and the respective entity that they sync: if a sync manager row was to be deleted, the related Flaw/Tracker would be deleted on cascade.
This PR unblocks #1145