Skip to content

Build launch description sooner so it can be reused#232

Merged
kkaarreell merged 1 commit into
mainfrom
ks_launch_desc
Jun 4, 2025
Merged

Build launch description sooner so it can be reused#232
kkaarreell merged 1 commit into
mainfrom
ks_launch_desc

Conversation

@kkaarreell

@kkaarreell kkaarreell commented Jun 4, 2025

Copy link
Copy Markdown
Collaborator

Summary by Sourcery

Move launch description preparation to an earlier point in the schedule workflow so that it can be reused for existing launches and avoid code duplication.

Enhancements:

  • Build the RP launch description before checking for an existing launch to enable its reuse when restarting requests
  • Remove duplicate launch description assembly code to centralize its construction

@kkaarreell kkaarreell self-assigned this Jun 4, 2025
@sourcery-ai

sourcery-ai Bot commented Jun 4, 2025

Copy link
Copy Markdown

Reviewer's Guide

The PR refactors the launch description assembly in CLI scheduling so that it’s constructed once (including existing description, line breaks, JIRA link, and job count) before checking for an existing launch UUID, eliminating duplicated code when creating or reusing launches.

File-Level Changes

Change Details Files
Extracted and unified launch description assembly
  • Build initial description before UUID check
  • Append HTML breaks when a base description exists
  • Include JIRA issue link if applicable
  • Append total job count
newa/cli.py
Removed redundant description block under launch creation
  • Deleted duplicate launch_description logic inside creation branch
newa/cli.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @kkaarreell - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟡 General issues: 1 issue found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Comment thread newa/cli.py Outdated
@jharuda

jharuda commented Jun 4, 2025

Copy link
Copy Markdown
Contributor

LGTM

@kkaarreell kkaarreell merged commit 7862a90 into main Jun 4, 2025
13 checks passed
@kkaarreell kkaarreell deleted the ks_launch_desc branch June 4, 2025 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants