Fix: Correct iteration count log message in issue-config processing#358
Merged
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideAdjusts the iteration count in a Jira helper log message to correctly reflect the number of iterations created when expanding issue config actions. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Using
i + 1in the final log will raise an exception if the loop never runs (no iterations created); consider tracking acountvariable initialized to 0 or usinglen(...)so the log remains robust when no actions are expanded.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Using `i + 1` in the final log will raise an exception if the loop never runs (no iterations created); consider tracking a `count` variable initialized to 0 or using `len(...)` so the log remains robust when no actions are expanded.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
The log message reporting the number of iterations created was off by one. Changed to use len(action.iterate) instead of the loop index variable, which is more robust and prevents potential errors if the loop doesn't execute. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
7bf92e8 to
2995f3b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The log message reporting the number of iterations created was off by one. The loop variable 'i' from enumerate() is 0-based, so for 5 iterations (iter1-iter5), it would log "Created 4 iterations" instead of the correct "Created 5 iterations".
Changed the log message to use 'i + 1' to report the accurate count.
🤖 Generated with Claude Code
Summary by Sourcery
Bug Fixes: