Add architecture info to list command TF request output#369
Merged
Conversation
Display architecture alongside artifacts URL in 'newa list' output to help users quickly identify which architecture a test request was executed on. Resolves: #368 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Reviewer's guide (collapsed on small PRs)Reviewer's GuideAdds architecture information to the Flow diagram for updated newa list architecture outputflowchart TD
A[Execute newa list] --> B[Iterate execute_job]
B --> C[Get artifacts_url from execute_job.execution]
B --> D[Get arch from execute_job.request]
D --> E{arch is not None?}
E -- Yes --> F[arch_suffix = ', arch: ' + arch.value]
E -- No --> G[arch_suffix = empty string]
C --> H[Format line with colored_state, colored_result, artifacts_url + arch_suffix]
F --> H
G --> H
H --> I[Print formatted line]
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- When building
arch_suffix, you assumearchhas a.valueattribute; ifarchcan be a plain string or another type in some cases, consider usingstr(arch)(or handling both Enum and non-Enum) to avoid potential attribute errors.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- When building `arch_suffix`, you assume `arch` has a `.value` attribute; if `arch` can be a plain string or another type in some cases, consider using `str(arch)` (or handling both Enum and non-Enum) to avoid potential attribute errors.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Collaborator
Author
The converter=Arch ensures that any value assigned to arch is automatically converted to an Arch enum. This means arch should only ever be:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Display architecture alongside artifacts URL in 'newa list' output to help users quickly identify which architecture a test request was executed on.
Resolves: #368
🤖 Generated with Claude Code
Summary by Sourcery
New Features:
newa listcommand output when available.