Add --full option to list command for RP descriptions#378
Merged
Conversation
Enhance the list command with a new --full flag that displays ReportPortal launch and suite descriptions for more detailed output. Changes: - Add --full flag to list command - Display RP launch description before URL when --full is enabled - Display RP suite description on same line as REQ ID when --full is enabled and it differs from launch description - Move recipe URL indentation one level left (from 6 to 4 spaces) - Indent status lines when suite description is shown - Add cyan color for REQ ID and description lines - Apply ReportPortal color (purple) to launch descriptions Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Reviewer's GuideAdds a --full flag to the list command to show more detailed ReportPortal metadata (launch and suite descriptions), adjusts indentation/formatting of recipe and status lines, and introduces a cyan color used for request IDs and description lines. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The indentation logic in
print_state_dirs(e.g., the hardcoded 4/6/8/10 values andstatus_indenthandling) is getting a bit brittle; consider centralizing indentation constants or adding a small helper to derive indents so that layout changes are easier to reason about and maintain. - In
print_state_dirs,request_id_coloris now computed but no longer used after switching REQ ID output toColors.CYAN; either remove this variable or route the color choice through a single path to avoid dead code.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The indentation logic in `print_state_dirs` (e.g., the hardcoded 4/6/8/10 values and `status_indent` handling) is getting a bit brittle; consider centralizing indentation constants or adding a small helper to derive indents so that layout changes are easier to reason about and maintain.
- In `print_state_dirs`, `request_id_color` is now computed but no longer used after switching REQ ID output to `Colors.CYAN`; either remove this variable or route the color choice through a single path to avoid dead code.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Address code review feedback by introducing a helper function to calculate indentation based on nesting level. This makes the code more maintainable and allows for future customization of indentation. Changes: - Add _indent() helper function to derive indents from nesting level - Replace all hardcoded indentation values (2, 4, 6, 8, 10) with _indent(level) calls - Define base indentation unit (2 spaces) that can be customized - Document nesting levels in _indent() docstring for clarity This refactoring improves code maintainability without changing the visual output or behavior of the list command. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Modify list command to display recipe URLs only when --full flag is enabled, reducing visual clutter in the default listing mode. The recipe line (with URL and optional [no-auto-schedule] indicator) is now part of the extended details shown only with --full. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Collaborator
Author
|
/packit test |
Collaborator
Author
|
/packit build |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enhance the list command with a new --full flag that displays ReportPortal launch and suite descriptions for more detailed output.
Changes:
Summary by Sourcery
Add a --full mode to the list command to show enriched ReportPortal metadata and adjust list output formatting and colors.
New Features:
Enhancements: