Skip to content

Change deduplicate_releases default to enabled#385

Merged
kkaarreell merged 1 commit into
mainfrom
ks_dedupl_def
Jul 1, 2026
Merged

Change deduplicate_releases default to enabled#385
kkaarreell merged 1 commit into
mainfrom
ks_dedupl_def

Conversation

@kkaarreell

@kkaarreell kkaarreell commented Jul 1, 2026

Copy link
Copy Markdown
Collaborator

Summary by Sourcery

Enable release deduplication by default and update tests to reflect the new default behavior.

Enhancements:

  • Change settings so Errata Tool release deduplication is enabled by default via both code and configuration parsing.

Tests:

  • Update CLI tests to assert that deduplication now occurs by default when no config or flag is provided.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@kkaarreell kkaarreell self-assigned this Jul 1, 2026
@sourcery-ai

sourcery-ai Bot commented Jul 1, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR changes the default behavior of release deduplication from disabled to enabled, updates configuration defaults accordingly, and adjusts the CLI test to validate the new default behavior.

File-Level Changes

Change Details Files
Enable deduplication of releases by default across settings and configuration handling.
  • Change the Settings model default for release deduplication from False to True.
  • Update configuration parsing to default the NEWA_ET_DEDUPLICATE_RELEASES value to '1' when not explicitly set.
newa/models/settings.py
Update CLI tests to reflect that deduplication now occurs by default when no config or flag is provided.
  • Rename and reword the test case to describe deduplication being enabled by default.
  • Adjust the assertion to expect a single deduplicated event file instead of two separate files.
tests/unit/test_cli.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@tcornell-bus tcornell-bus left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kkaarreell kkaarreell merged commit 2043531 into main Jul 1, 2026
16 checks passed
@kkaarreell kkaarreell deleted the ks_dedupl_def branch July 1, 2026 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants