net: Drop cluster net stack fixtures#4365
Merged
rnetser merged 1 commit intoRedHatQE:mainfrom Apr 14, 2026
Merged
Conversation
|
Report bugs in Issues Welcome! 🎉This pull request will be automatically processed with the following features: 🔄 Automatic Actions
📋 Available CommandsPR Status Management
Review & Approval
Testing & Validation
Container Operations
Cherry-pick Operations
Label Management
✅ Merge RequirementsThis PR will be automatically approved when the following conditions are met:
📊 Review ProcessApprovers and ReviewersApprovers:
Reviewers:
Available Labels
AI Features
💡 Tips
For more information, please refer to the project documentation or contact the maintainers. |
openshift-virtualization-qe-bot
requested review from
Anatw,
EdDev,
OhadRevah,
dshchedr,
rlobillo,
rnetser,
servolkov and
yossisegev
Contributor
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughReplaced parameterized cluster IP-family check with two cached no-arg helpers Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
openshift-virtualization-qe-bot
added
tox:verify-tc-requirement-polarion:running
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@tests/network/l2_bridge/vmi_interfaces_stability/lib_helpers.py`:
- Around line 58-60: In primary_iface_cloud_init(), the guard currently checks
the function object ipv6_supported_cluster instead of calling it; change the
conditional to call ipv6_supported_cluster() so the code reads if not
ipv6_supported_cluster(): return None, matching the other uses of
ipv6_supported_cluster() and ipv4_supported_cluster() and ensuring IPv6-disabled
clusters return None.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: 59c5376f-204e-4010-8671-6e4beffdf685
📒 Files selected for processing (11)
libs/net/cluster.pytests/conftest.pytests/network/conftest.pytests/network/connectivity/conftest.pytests/network/connectivity/utils.pytests/network/l2_bridge/vmi_interfaces_stability/conftest.pytests/network/l2_bridge/vmi_interfaces_stability/lib_helpers.pytests/network/localnet/conftest.pytests/network/localnet/liblocalnet.pytests/network/sriov/conftest.pytests/observability/metrics/test_general_metrics.py
💤 Files with no reviewable changes (1)
- tests/network/sriov/conftest.py
azhivovk
force-pushed
the
drop_cluster_network_fixtures
branch
from
9b100b2 to
af84267
Compare
Contributor
Author
|
Change: Adjust usage of cached helper |
openshift-virtualization-qe-bot
added
tox:verify-tc-requirement-polarion:running
servolkov
approved these changes
Apr 13, 2026
Contributor
Author
|
/verified Single-stack IPv6 cluster with cnv-4.22: Dual-stack BM with cnv-4.22: |
Contributor
Test execution plan request detailsCRITICAL: You MUST post an inline review comment on the first changed line of the first file. As an expert software testing engineer, analyze all modified files in this PR and create a targeted test execution plan. Analysis Requirements:
Your deliverable: Test Execution Plan
Guidelines:
Hardware-Related Checks (SR-IOV, GPU, DPDK): When PR modifies fixtures for hardware-specific resources:
CRITICAL WORKFLOW COMPLETION RULES: When responding to this test execution plan request, you MUST follow these rules EXACTLY:
ABSOLUTE PROHIBITIONS (violating these creates empty/meaningless reviews):
Remember: The pull request review is visible to users. Additional comments are redundant noise. CRITICAL: Before setting "Run smoke tests: True", you MUST use shell scripts to: |
Contributor
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: Length of output: 4036 🏁 Script executed: Length of output: 675 🏁 Script executed: Length of output: 3149 🧠 Learnings used |
EdDev
reviewed
Apr 13, 2026
Contributor
EdDev
left a comment
EdDev
left a comment
There was a problem hiding this comment.
Thanks.
I had only a few comments, see inline.
Both ipv4_supported_cluster and ipv6_supported_cluster fixtures are used frequently as parameters. For cleaner data usage, these fixtures can be removed and replaced with cached helper functions that retrieve the cluster network stack once. Signed-off-by: Asia Khromov <azhivovk@redhat.com>
Contributor
Author
|
Contributor
Author
|
/verified |
servolkov
approved these changes
Apr 13, 2026
Contributor
Test execution plan request detailsCRITICAL: You MUST post an inline review comment on the first changed line of the first file. As an expert software testing engineer, analyze all modified files in this PR and create a targeted test execution plan. Analysis Requirements:
Your deliverable: Test Execution Plan
Guidelines:
Hardware-Related Checks (SR-IOV, GPU, DPDK): When PR modifies fixtures for hardware-specific resources:
CRITICAL WORKFLOW COMPLETION RULES: When responding to this test execution plan request, you MUST follow these rules EXACTLY:
ABSOLUTE PROHIBITIONS (violating these creates empty/meaningless reviews):
Remember: The pull request review is visible to users. Additional comments are redundant noise. CRITICAL: Before setting "Run smoke tests: True", you MUST use shell scripts to: |
Contributor
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: Length of output: 6669 🏁 Script executed: Length of output: 3253 🧠 Learnings used |
Collaborator
|
/approve |
This was referenced Apr 14, 2026
Contributor
|
New container for quay.io/openshift-cnv/openshift-virtualization-tests:latest published |
Contributor
Author
|
/cherry-pick cnv-4.21 |
|
Manual cherry-pick is needed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both ipv4_supported_cluster and ipv6_supported_cluster fixtures are used frequently as parameters.
For cleaner data usage, these fixtures can be removed and replaced with cached helper functions that retrieve the cluster network stack once.
jira-ticket: https://redhat.atlassian.net/browse/CNV-81266
Summary by CodeRabbit
Refactor
Tests