[Gating] Skip kubevirt-console-plugin pods in sanity checks#4413
Closed
hmeir wants to merge 1 commit intoRedHatQE:mainfrom
Closed
[Gating] Skip kubevirt-console-plugin pods in sanity checks#4413hmeir wants to merge 1 commit intoRedHatQE:mainfrom
hmeir wants to merge 1 commit intoRedHatQE:mainfrom
Conversation
Contributor
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 24 minutes and 4 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughImported Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Report bugs in Issues Welcome! 🎉This pull request will be automatically processed with the following features: 🔄 Automatic Actions
📋 Available CommandsPR Status Management
Review & Approval
Testing & Validation
Container Operations
Cherry-pick Operations
Label Management
✅ Merge RequirementsThis PR will be automatically approved when the following conditions are met:
📊 Review ProcessApprovers and ReviewersApprovers:
Reviewers:
Available Labels
AI Features
💡 Tips
For more information, please refer to the project documentation or contact the maintainers. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4413 +/- ##
==========================================
+ Coverage 98.63% 98.65% +0.02%
==========================================
Files 25 25
Lines 2420 2459 +39
==========================================
+ Hits 2387 2426 +39
Misses 33 33
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
openshift-virtualization-qe-bot
added
tox:verify-tc-requirement-polarion:running
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@utilities/infra.py`:
- Around line 208-210: Remove the unnecessary type-ignore suppressions on the
`in` operator by deleting the `# type: ignore[operator]` comments in the
conditional that checks `if KUBEVIRT_CONSOLE_PLUGIN in pod.name and
_is_console_plugin_bug_open():` and the related `LOGGER.warning(...)` line;
leave the logic using `KUBEVIRT_CONSOLE_PLUGIN`, `pod.name`,
`_is_console_plugin_bug_open`, and `LOGGER.warning` unchanged so the `in`
membership check is used without linter suppression.
- Around line 197-199: The _is_console_plugin_bug_open() function currently
calls is_jira_open() directly which can raise MissingEnvironmentVariableError or
JIRA/network exceptions and crash pod sanity checks; modify
_is_console_plugin_bug_open() to catch MissingEnvironmentVariableError and any
other Exception around the is_jira_open(jira_id="CNV-82451") call, log the
failure (use the module logger or logging.exception with a clear message
referencing CNV-82451 and is_jira_open), and return a safe default False so the
sanity check degrades gracefully; keep the `@cache` decorator and ensure the
exception handling returns False on error.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: 56d09b02-2585-4303-a257-fd48f6077692
📒 Files selected for processing (1)
utilities/infra.py
hmeir
force-pushed
the
skip-console-plugin-pods-in-sanity-check
branch
from
7810bd4 to
82fc4ac
Compare
openshift-virtualization-qe-bot
added
lgtm-coderabbitai[bot]
tox:verify-tc-requirement-polarion:running
Because of CNV-82451 bug, those pods crashing. We should skip them until the bug is fixed, to allow clean runs. Signed-off-by: Harel Meir <hmeir@redhat.com>
hmeir
force-pushed
the
skip-console-plugin-pods-in-sanity-check
branch
from
a184a6a to
dabfc8f
Compare
openshift-virtualization-qe-bot
added
tox:verify-tc-requirement-polarion:running
Contributor
Author
|
/verified |
Contributor
Test execution plan request detailsCRITICAL: You MUST post an inline review comment on the first changed line of the first file. As an expert software testing engineer, analyze all modified files in this PR and create a targeted test execution plan. Analysis Requirements:
Your deliverable: Test Execution Plan
Guidelines:
Hardware-Related Checks (SR-IOV, GPU, DPDK): When PR modifies fixtures for hardware-specific resources:
CRITICAL WORKFLOW COMPLETION RULES: When responding to this test execution plan request, you MUST follow these rules EXACTLY:
ABSOLUTE PROHIBITIONS (violating these creates empty/meaningless reviews):
Remember: The pull request review is visible to users. Additional comments are redundant noise. CRITICAL: Before setting "Run smoke tests: True", you MUST use shell scripts to: |
Contributor
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: Length of output: 1973 🧠 Learnings used |
RoniKishner
reviewed
Apr 14, 2026
Collaborator
|
/approve |
RoniKishner
approved these changes
Apr 14, 2026
Contributor
|
/retest all Auto-triggered: Files in this PR were modified by merged PR #4392. Overlapping filesutilities/infra.py |
Contributor
Author
|
already fixed. closing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description:
Because of CNV-82451 bug, those pods crashing.
We should skip them until the bug is fixed.
More details:
What this PR does / why we need it:
Which issue(s) this PR fixes:
Its failing almost every lane in downstream runs.
Special notes for reviewer:
jira-ticket:
https://redhat.atlassian.net/browse/CNV-84100
Summary by CodeRabbit