[4.20][Storage] Storage Tier2: use DataSource instead of artifactory in test_wffc.py 4.20#4531
Open
acinko-rh wants to merge 6 commits intoRedHatQE:cnv-4.20from
Open
Conversation
…t_wffc.py (RedHatQE#4368) Use DataSource instead of artifactory in test_wffc.py https://redhat.atlassian.net/browse/CNV-83360 Currently, most storage tests use import from HTTP as the default method to deploy DataVolumes/VMs. Switching to golden images (except for tests that explicitly validate the import workflow) will improve test stability and reduce flakiness. Acceptance criteria: Update storage tests to use golden image as the default deployment method. Keep HTTP import only for tests explicitly covering import functionality. In `test_wffc.py` the tests are using HTTP to create DVs which can make them fail when the requrest for the image is unsuccessful. Don't hold out on critisism, I'm new and I want to get better. <!-- full-ticket-url needs to be provided. This would add a link to the pull request to the jira and close it when the pull request is merged If the task is not tracked by a Jira ticket, just write "NONE". --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> * **Tests** * Switched storage tests to use RHEL images and updated VM memory to match RHEL. * Replaced external-image/template workflow with a blank-source DataVolume flow and added reusable blank DV and DV-template fixtures. * Consolidated storage-class selection into a single module-scoped fixture and improved virtctl/upload wiring. * Simplified runtime waiting and VMI status handling. * Removed two obsolete registry/clone tests and updated affected test parametrization. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Signed-off-by: Adam Cinko <acinko@redhat.com>
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
|
Report bugs in Issues Welcome! 🎉This pull request will be automatically processed with the following features: 🔄 Automatic Actions
📋 Available CommandsPR Status Management
Review & Approval
Testing & Validation
Container Operations
Cherry-pick Operations
Label Management
✅ Merge RequirementsThis PR will be automatically approved when the following conditions are met:
📊 Review ProcessApprovers and ReviewersApprovers:
Reviewers:
Available Labels
AI Features
💡 Tips
For more information, please refer to the project documentation or contact the maintainers. |
openshift-virtualization-qe-bot-2
requested review from
dalia-frank and
josemacassan
for more information, see https://pre-commit.ci
openshift-virtualization-qe-bot-2
requested review from
Ahmad-Hafe and
kshvaika
acinko-rh
changed the title
openshift-virtualization-qe-bot
added
tox:verify-tc-requirement-polarion:running
Signed-off-by: Adam Cinko <acinko@redhat.com>
openshift-virtualization-qe-bot
added
tox:verify-tc-requirement-polarion:running
Contributor
|
Clean rebase detected — no code changes compared to previous head ( |
Contributor
Author
|
/build-and-push-container |
Contributor
Author
|
/verify cancel |
|
New container for quay.io/openshift-cnv/openshift-virtualization-tests:pr-4531 published |
openshift-virtualization-qe-bot
added
tox:verify-tc-requirement-polarion:running
Contributor
Author
|
/verified |
Contributor
Test execution plan request detailsCRITICAL: You MUST post an inline review comment on the first changed line of the first file. As an expert software testing engineer, analyze all modified files in this PR and create a targeted test execution plan. Analysis Requirements:
Your deliverable: Test Execution Plan
Guidelines:
Hardware-Related Checks (SR-IOV, GPU, DPDK): When PR modifies fixtures for hardware-specific resources:
CRITICAL WORKFLOW COMPLETION RULES: When responding to this test execution plan request, you MUST follow these rules EXACTLY:
ABSOLUTE PROHIBITIONS (violating these creates empty/meaningless reviews):
Remember: The pull request review is visible to users. Additional comments are redundant noise. CRITICAL: Before setting "Run smoke tests: True", you MUST use shell scripts to: |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: Length of output: 943 🏁 Script executed: Length of output: 1735 🧠 Learnings used |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…t_wffc.py (#4368)
Use DataSource instead of artifactory in test_wffc.py
https://redhat.atlassian.net/browse/CNV-83360
Currently, most storage tests use import from HTTP as the default method to deploy DataVolumes/VMs.
Switching to golden images (except for tests that explicitly validate the import workflow) will improve test stability and reduce flakiness.
Acceptance criteria:
Update storage tests to use golden image as the default deployment method.
Keep HTTP import only for tests explicitly covering import functionality.
In
test_wffc.pythe tests are using HTTP to create DVs which can make them fail when the requrest for the image is unsuccessful.Don't hold out on critisism, I'm new and I want to get better.