IUO: fix and refactor custom golden images namespace tests#4595
Open
hmeir wants to merge 2 commits intoRedHatQE:mainfrom
Open
IUO: fix and refactor custom golden images namespace tests#4595hmeir wants to merge 2 commits intoRedHatQE:mainfrom
hmeir wants to merge 2 commits intoRedHatQE:mainfrom
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (2)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughThe test module removes timeout-based polling and reconciliation helpers, materializes resource enumeration generators before set operations, stops asserting absence for non-DataSource types in the custom-namespace test, and replaces the default-namespace reconciliation test with subtests that directly assert deletion of specific resource kinds. A shared utility that deleted resources by type was removed. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Report bugs in Issues Welcome! 🎉This pull request will be automatically processed with the following features: 🔄 Automatic Actions
📋 Available CommandsPR Status Management
Review & Approval
Testing & Validation
Container Operations
Cherry-pick Operations
Label Management
✅ Merge RequirementsThis PR will be automatically approved when the following conditions are met:
📊 Review ProcessApprovers and ReviewersApprovers:
Reviewers:
Available Labels
AI Features
💡 Tips
For more information, please refer to the project documentation or contact the maintainers. |
openshift-virtualization-qe-bot-4
requested review from
OhadRevah,
albarker-rh,
dshchedr and
vsibirsk
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
openshift-virtualization-qe-bot
added
tox:verify-tc-requirement-polarion:running
Contributor
Author
|
/retest tox |
Bug fix: - Fix generator exhaustion in verify_resource_in_ns; resource_type.get() was consumed by set comprehension, causing wait_for_condition to silently skip all resources Test refactor: - Split test_resources_in_custom_ns to only verify resources exist and are ready in the custom namespace - Add test_resources_deleted_from_default_namespace to verify DataImportCron, ImageStream, DataVolume, and VolumeSnapshot are absent from the default namespace, using subtests Signed-off-by: Harel Meir <hmeir@redhat.com> Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
hmeir
force-pushed
the
fix-consumed-generator
branch
from
73db8cc to
5b4860a
Compare
for more information, see https://pre-commit.ci
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4595 +/- ##
==========================================
+ Coverage 98.63% 98.66% +0.03%
==========================================
Files 25 25
Lines 2420 2476 +56
==========================================
+ Hits 2387 2443 +56
Misses 33 33
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
openshift-virtualization-qe-bot
added
lgtm-coderabbitai[bot]
tox:verify-tc-requirement-polarion:running
Contributor
Author
|
/verified |
Contributor
Test execution plan request detailsCRITICAL: You MUST post an inline review comment on the first changed line of the first file. As an expert software testing engineer, analyze all modified files in this PR and create a targeted test execution plan. Analysis Requirements:
Your deliverable: Test Execution Plan
Guidelines:
Hardware-Related Checks (SR-IOV, GPU, DPDK): When PR modifies fixtures for hardware-specific resources:
CRITICAL WORKFLOW COMPLETION RULES: When responding to this test execution plan request, you MUST follow these rules EXACTLY:
ABSOLUTE PROHIBITIONS (violating these creates empty/meaningless reviews):
Remember: The pull request review is visible to users. Additional comments are redundant noise. CRITICAL: Before setting "Run smoke tests: True", you MUST use shell scripts to: |
| from ocp_resources.ssp import SSP | ||
| from ocp_resources.volume_snapshot import VolumeSnapshot | ||
| from timeout_sampler import TimeoutExpiredError, TimeoutSampler | ||
|
|
Contributor
There was a problem hiding this comment.
Test Execution Plan
-
Run smoke tests: False
- No smoke tests depend on
delete_resources_from_namespace_by_type(removed fromutilities/infra.py) - No smoke tests import or depend on
test_custom_golden_images_namespace.py
- No smoke tests depend on
-
tests/install_upgrade_operators/hco_enablement_golden_image_updates/test_custom_golden_images_namespace.py— full file: bug fix toverify_resource_in_ns(generator materialization), refactoredtest_resources_in_custom_ns, and newtest_resources_deleted_from_default_namespaceall require verification
Contributor
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: Length of output: 3520 🏁 Script executed: Length of output: 41 🏁 Script executed: Length of output: 273 🏁 Script executed: Length of output: 1735 🧠 Learnings used |
Contributor
Author
|
/build-and-push-container |
|
New container for quay.io/openshift-cnv/openshift-virtualization-tests:pr-4595 published |
dshchedr
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description:
Fixed a bug caused by generator exhaustion, resulting in false positives.
In addition, refactored the tests to support the new change for the golden images.
More details:
Bug fix:
Test refactor:
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for reviewer:
jira-ticket:
https://redhat.atlassian.net/browse/CNV-85505
Summary by CodeRabbit
Tests
Chores
Note: Internal testing changes only; no user-facing behavior was modified.