[4.20] [Storage] Use ssh retries in run_ssh_commands (#4471) by jpeimer · Pull Request #4597 · RedHatQE/openshift-virtualization-tests

jpeimer · 2026-04-27T07:42:46Z

Short description:

Backport: #4471

More details:

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for reviewer:

jira-ticket:

* **Tests** * Standardized retry timeouts and polling for remote command execution across storage tests for more reliable, consistent test behavior. * Switched tests to use a consolidated shared helper for running commands and validating remote output. * **Chores** * Removed unused imports and deleted redundant test helpers to reduce duplication and simplify maintenance. * Added a shared helper for command-and-assert operations used by multiple tests.  --------- Signed-off-by: Jenia Peimer <jpeimer@redhat.com> Signed-off-by: rnetser <rnetser@redhat.com> Signed-off-by: Nir Dothan <ndothan@redhat.com> Signed-off-by: Yossi Segev <ysegev@redhat.com> Co-authored-by: Ruth Netser <rnetser@redhat.com> Co-authored-by: Nir Dothan <ndothan@redhat.com> Co-authored-by: Yossi Segev <40713576+yossisegev@users.noreply.github.com>

coderabbitai · 2026-04-27T07:42:53Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 54ffa536-e362-4c96-b3c7-ca6d48e5c403

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

openshift-virtualization-qe-bot-4 · 2026-04-27T07:43:34Z

Report bugs in Issues

Welcome! 🎉

This pull request will be automatically processed with the following features:

🔄 Automatic Actions

Reviewer Assignment: Reviewers are automatically assigned based on the OWNERS file in the repository root
Size Labeling: PR size labels (XS, S, M, L, XL, XXL) are automatically applied based on changes
Issue Creation: A tracking issue is created for this PR and will be closed when the PR is merged or closed
Branch Labeling: Branch-specific labels are applied to track the target branch
Auto-verification: Auto-verified users have their PRs automatically marked as verified
Labels: Enabled categories: branch, can-be-merged, cherry-pick, has-conflicts, hold, needs-rebase, size, verified, wip

📋 Available Commands

PR Status Management

/wip - Mark PR as work in progress (adds WIP: prefix to title)
/wip cancel - Remove work in progress status
/hold - Block PR merging (approvers only)
/hold cancel - Unblock PR merging
/verified - Mark PR as verified
/verified cancel - Remove verification status
/reprocess - Trigger complete PR workflow reprocessing (useful if webhook failed or configuration changed)
/regenerate-welcome - Regenerate this welcome message

Review & Approval

/lgtm - Approve changes (looks good to me)
/approve - Approve PR (approvers only)
/assign-reviewers - Assign reviewers based on OWNERS file
/assign-reviewer @username - Assign specific reviewer
/check-can-merge - Check if PR meets merge requirements

Testing & Validation

/retest tox - Run Python test suite with tox
/retest build-container - Rebuild and test container image
/retest verify-bugs-are-open - verify-bugs-are-open
/retest all - Run all available tests

Container Operations

/build-and-push-container - Build and push container image (tagged with PR number)
- Supports additional build arguments: /build-and-push-container --build-arg KEY=value

Cherry-pick Operations

/cherry-pick <branch> - Schedule cherry-pick to target branch when PR is merged
- Multiple branches: /cherry-pick branch1 branch2 branch3

Label Management

/<label-name> - Add a label to the PR
/<label-name> cancel - Remove a label from the PR

✅ Merge Requirements

This PR will be automatically approved when the following conditions are met:

Approval: /approve from at least one approver
LGTM Count: Minimum 2 /lgtm from reviewers
Status Checks: All required status checks must pass
No Blockers: No wip, hold, has-conflicts labels and PR must be mergeable (no conflicts)
Verified: PR must be marked as verified

📊 Review Process

Approvers and Reviewers

Approvers:

dshchedr
jpeimer
myakove
rnetser
vsibirsk

Reviewers:

Ahmad-Hafe
RoniKishner
acinko-rh
dalia-frank
dshchedr
ema-aka-young
geetikakay
josemacassan
jpeimer
kgoldbla
kshvaika
rnetser
vsibirsk

Available Labels

hold
verified
wip
lgtm
approve

AI Features

Cherry-Pick Conflict Resolution: Enabled (claude/claude-opus-4-6[1m])

💡 Tips

WIP Status: Use /wip when your PR is not ready for review
Verification: The verified label is removed on new commits unless the push is detected as a clean rebase
Cherry-picking: Cherry-pick labels are processed when the PR is merged
Container Builds: Container images are automatically tagged with the PR number
Permission Levels: Some commands require approver permissions
Auto-verified Users: Certain users have automatic verification and merge privileges

For more information, please refer to the project documentation or contact the maintainers.

Signed-off-by: Jenia Peimer <jpeimer@redhat.com>

jpeimer · 2026-04-27T08:43:14Z

/build-and-push-container

openshift-virtualization-qe-bot-3 · 2026-04-27T09:36:33Z

New container for quay.io/openshift-cnv/openshift-virtualization-tests:pr-4597 published

ema-aka-young · 2026-04-27T13:31:25Z

/lgtm

github-actions Bot added the sig-storage label Apr 27, 2026

jpeimer changed the title ~~[Storage] Use ssh retries in run_ssh_commands (#4471)~~ [4.20] [Storage] Use ssh retries in run_ssh_commands (#4471) Apr 27, 2026

openshift-virtualization-qe-bot-4 requested a review from Ahmad-Hafe April 27, 2026 07:43

openshift-virtualization-qe-bot-4 assigned jpeimer Apr 27, 2026

openshift-virtualization-qe-bot-4 mentioned this pull request Apr 27, 2026

[4.20] [Storage] Use ssh retries in run_ssh_commands (#4471) - 4597 #4598

Open

openshift-virtualization-qe-bot-4 added the branch-cnv-4.20 label Apr 27, 2026

openshift-virtualization-qe-bot-4 requested review from dshchedr and vsibirsk April 27, 2026 07:43

openshift-virtualization-qe-bot-4 added the size/L label Apr 27, 2026

openshift-virtualization-qe-bot-4 requested review from dalia-frank, geetikakay, josemacassan, kshvaika and rnetser April 27, 2026 07:43

openshift-virtualization-qe-bot-2 requested review from RoniKishner and ema-aka-young April 27, 2026 07:44

openshift-virtualization-qe-bot-4 requested a review from acinko-rh April 27, 2026 07:44

openshift-virtualization-qe-bot-2 requested a review from kgoldbla April 27, 2026 07:44

openshift-virtualization-qe-bot added tox:verify-tc-requirement-polarion:running D/S Testing tox:verify-tc-requirement-polarion:passed D/S Testing and removed tox:verify-tc-requirement-polarion:running D/S Testing labels Apr 27, 2026

Fix merge conflicts

74bfff8

Signed-off-by: Jenia Peimer <jpeimer@redhat.com>

jpeimer force-pushed the 420_use_ssh_retries branch from df28125 to 74bfff8 Compare April 27, 2026 08:12

openshift-virtualization-qe-bot added tox:verify-tc-requirement-polarion:running D/S Testing tox:verify-tc-requirement-polarion:passed D/S Testing and removed tox:verify-tc-requirement-polarion:passed D/S Testing tox:verify-tc-requirement-polarion:running D/S Testing labels Apr 27, 2026

Fix tox

6075ba3

Signed-off-by: Jenia Peimer <jpeimer@redhat.com>

openshift-virtualization-qe-bot added tox:verify-tc-requirement-polarion:running D/S Testing tox:verify-tc-requirement-polarion:passed D/S Testing and removed tox:verify-tc-requirement-polarion:passed D/S Testing tox:verify-tc-requirement-polarion:running D/S Testing labels Apr 27, 2026

openshift-virtualization-qe-bot-4 added the lgtm-ema-aka-young label Apr 27, 2026

openshift-virtualization-qe-bot-2 added the needs-rebase label Apr 27, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[4.20] [Storage] Use ssh retries in run_ssh_commands (#4471)#4597

[4.20] [Storage] Use ssh retries in run_ssh_commands (#4471)#4597
jpeimer wants to merge 3 commits intoRedHatQE:cnv-4.20from
jpeimer:420_use_ssh_retries

jpeimer commented Apr 27, 2026

Uh oh!

coderabbitai Bot commented Apr 27, 2026 •

edited

Loading

Review skipped

Uh oh!

openshift-virtualization-qe-bot-4 commented Apr 27, 2026

Uh oh!

jpeimer commented Apr 27, 2026

Uh oh!

openshift-virtualization-qe-bot-3 commented Apr 27, 2026

Uh oh!

ema-aka-young commented Apr 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

jpeimer commented Apr 27, 2026

Short description:

More details:

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for reviewer:

jira-ticket:

Uh oh!

coderabbitai Bot commented Apr 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

openshift-virtualization-qe-bot-4 commented Apr 27, 2026

Welcome! 🎉

🔄 Automatic Actions

📋 Available Commands

PR Status Management

Review & Approval

Testing & Validation

Container Operations

Cherry-pick Operations

Label Management

✅ Merge Requirements

📊 Review Process

💡 Tips

Uh oh!

jpeimer commented Apr 27, 2026

Uh oh!

openshift-virtualization-qe-bot-3 commented Apr 27, 2026

Uh oh!

ema-aka-young commented Apr 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

coderabbitai Bot commented Apr 27, 2026 •

edited

Loading