infra: Add test for rhel vm with d1 instance type#4609
Open
RoniKishner wants to merge 1 commit intoRedHatQE:mainfrom
Open
infra: Add test for rhel vm with d1 instance type#4609RoniKishner wants to merge 1 commit intoRedHatQE:mainfrom
RoniKishner wants to merge 1 commit intoRedHatQE:mainfrom
Conversation
Signed-off-by: rkishner <rkishner@redhat.com>
Contributor
📝 WalkthroughWalkthroughUpdates VM preference handling in the Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Report bugs in Issues Welcome! 🎉This pull request will be automatically processed with the following features: 🔄 Automatic Actions
📋 Available CommandsPR Status Management
Review & Approval
Testing & Validation
Container Operations
Cherry-pick Operations
Label Management
✅ Merge RequirementsThis PR will be automatically approved when the following conditions are met:
📊 Review ProcessApprovers and ReviewersApprovers:
Reviewers:
Available Labels
AI Features
💡 Tips
For more information, please refer to the project documentation or contact the maintainers. |
Contributor
Author
|
/verified |
Contributor
Test execution plan request detailsCRITICAL: You MUST post an inline review comment on the first changed line of the first file. As an expert software testing engineer, analyze all modified files in this PR and create a targeted test execution plan. Analysis Requirements:
Your deliverable: Test Execution Plan
Guidelines:
Hardware-Related Checks (SR-IOV, GPU, DPDK): When PR modifies fixtures for hardware-specific resources:
CRITICAL WORKFLOW COMPLETION RULES: When responding to this test execution plan request, you MUST follow these rules EXACTLY:
ABSOLUTE PROHIBITIONS (violating these creates empty/meaningless reviews):
Remember: The pull request review is visible to users. Additional comments are redundant noise. CRITICAL: Before setting "Run smoke tests: True", you MUST use shell scripts to: |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: Length of output: 115 🏁 Script executed: Length of output: 2848 🏁 Script executed: Length of output: 41 🏁 Script executed: Length of output: 1735 🧠 Learnings used |
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@tests/infrastructure/instance_types/conftest.py`:
- Around line 176-190: The rhel_vm_for_dedicated_cpu fixture is hardcoding the
VM name and instance type which diverges from the pattern used by
windows_vm_for_dedicated_cpu; change rhel_vm_for_dedicated_cpu to accept the
pytest request fixture and read vm_name and instance_type_name from
request.param (or support default values) and pass those into
VirtualMachineForTests (replace the literal "rhel-d1-vm" with vm_name and
VirtualMachineClusterInstancetype(... name="d1.large") with instance_type_name)
so the fixture can be parametrized the same way as windows_vm_for_dedicated_cpu.
In `@tests/infrastructure/instance_types/test_common_vm_instancetype.py`:
- Around line 101-106: The test test_d1_on_rhel_vm unnecessarily inherits
class-level Windows fixtures (windows_validating_admission_policy,
windows_validating_admission_policy_binding) from
TestDedicatedInstancetypeProfile; move test_d1_on_rhel_vm out of the
TestDedicatedInstancetypeProfile class into a module-level test or a small
sibling class so it no longer picks up those Windows-only fixtures, ensuring it
simply calls running_vm(vm=rhel_vm_for_dedicated_cpu) without the cluster-scoped
ValidatingAdmissionPolicy setup/teardown.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: b248f401-14b4-4b19-b52d-dd923f5a8b77
📒 Files selected for processing (2)
tests/infrastructure/instance_types/conftest.pytests/infrastructure/instance_types/test_common_vm_instancetype.py
openshift-virtualization-qe-bot
added
tox:verify-tc-requirement-polarion:running
openshift-virtualization-qe-bot-2
added
lgtm-coderabbitai[bot]
and removed
changes-requested-coderabbitai[bot]
labels
geetikakay
reviewed
Apr 28, 2026
| vm_instance_type=VirtualMachineClusterInstancetype(client=unprivileged_client, name="d1.large"), | ||
| vm_preference_infer=True, | ||
| data_volume_template=data_volume_template_with_source_ref_dict( | ||
| data_source=rhel10_data_source_scope_session, |
Contributor
There was a problem hiding this comment.
maybe use data_source=latest_rhel_data_source
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description:
Add test for rhel vm with d1 instance type
More details:
What this PR does / why we need it:
Add test converge
jira-ticket:
https://redhat.atlassian.net/browse/CNV-79339
Summary by CodeRabbit