CherryPicked: [cnv-4.21] Add SecureExecution feature gate to expected KubeVirt feature gates for s390x#4618
Open
laxmi-333 wants to merge 2 commits intoRedHatQE:cnv-4.21from
Open
Conversation
…or s390x (RedHatQE#4156) Add SecureExecution featuregate support for s390x in featuregate tests SecureExecution is a feature gate present in the KubeVirt CR on s390x clusters. The existing feature gate tests were failing on s390x because the expected feature gate set did not include SecureExecution. This PR introduces `EXPECTED_KUBEVIRT_S390X_FEATUREGATES` and conditionally merges it into the expected feature gates using the `is_s390x_cluster` fixture. Ensures feature gate tests pass on s390x by including SecureExecution in the expected KubeVirt feature gates. Without this change, the following tests fail on s390x clusters because SecureExecution is present in the KubeVirt CR but missing from the expected set: - test_managed_cr_featuregate_reconcile[delete_featuregates_kubevirt_cr] - test_default_featuregates_by_resource[verify_defaults_featuregates_kubevirt_cr] <!-- full-ticket-url needs to be provided. This would add a link to the pull request to the jira and close it when the pull request is merged If the task is not tracked by a Jira ticket, just write "NONE". --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> * **Tests** * Added s390x-specific expected feature-gates and a fixture that computes expected feature-gates per architecture. * Introduced an expected-value fixture and updated test parameterization/parameter names for clarity. * Expanded test coverage to validate default and reconciled KubeVirt feature-gates across architectures. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Signed-off-by: Laxmi Adavalli <laxmi.adavalli@ibm.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (4)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Report bugs in Issues Welcome! 🎉This pull request will be automatically processed with the following features: 🔄 Automatic Actions
📋 Available CommandsPR Status Management
Review & Approval
Testing & Validation
Container Operations
Cherry-pick Operations
Label Management
✅ Merge RequirementsThis PR will be automatically approved when the following conditions are met:
📊 Review ProcessApprovers and ReviewersApprovers:
Reviewers:
Available Labels
AI Features
💡 Tips
For more information, please refer to the project documentation or contact the maintainers. |
openshift-virtualization-qe-bot-5
requested review from
albarker-rh and
vsibirsk
for more information, see https://pre-commit.ci
openshift-virtualization-qe-bot-5
requested review from
OhadRevah,
dshchedr,
hmeir and
rlobillo
openshift-virtualization-qe-bot
added
tox:verify-tc-requirement-polarion:running
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick from main branch, original PR: #4156
Short description:
Add SecureExecution featuregate support for s390x in featuregate tests
More details:
SecureExecution is a feature gate present in the KubeVirt CR on s390x clusters. The existing feature gate tests were failing on s390x because the expected feature gate set did not include SecureExecution.
This PR introduces EXPECTED_KUBEVIRT_S390X_FEATUREGATES and conditionally merges it into the expected feature gates using the is_s390x_cluster fixture.
What this PR does / why we need it:
Ensures feature gate tests pass on s390x by including SecureExecution in the expected KubeVirt feature gates. Without this change, the following tests fail on s390x clusters because SecureExecution is present in the KubeVirt CR but missing from the expected set:
test_managed_cr_featuregate_reconcile[delete_featuregates_kubevirt_cr]
test_default_featuregates_by_resource[verify_defaults_featuregates_kubevirt_cr]
Which issue(s) this PR fixes:
Special notes for reviewer:
jira-ticket: