Update VIRT_ALERTS_LIST with new and missing virt component alerts#5361
Conversation
Add 5 new alerts from CNV-71204 (VirtHandlerDown, LowReadyVirtAPICount, NoReadyVirtAPI, LowReadyVirtHandlerCount, NoReadyVirtHandler) and 3 alerts that were previously missing (VirtControllerDown, LowVirtAPICount, LowVirtControllersCount). Remove duplicate LowVirtOperatorCount entry and organize list by component. jira-ticket: CNV-71204 assisted by: claude code claude-opus-4-6 Signed-off-by: Ohad <orevah@redhat.com>
|
Report bugs in Issues Welcome! 🎉This pull request will be automatically processed with the following features: 🔄 Automatic Actions
📋 Available CommandsPR Status Management
Review & Approval
Testing & Validation
Container Operations
Cherry-pick Operations
Branch Management
Label Management
✅ Merge RequirementsThis PR will be automatically approved when the following conditions are met:
📊 Review ProcessApprovers and ReviewersApprovers:
Reviewers:
Available Labels
AI Features
Security Checks
💡 Tips
For more information, please refer to the project documentation or contact the maintainers. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
📜 Recent review details⏰ Context from checks skipped due to timeout. (11)
🧰 Additional context used📓 Path-based instructions (3)**/*.py📄 CodeRabbit inference engine (AGENTS.md)
Files:
tests/**/*.py📄 CodeRabbit inference engine (AGENTS.md)
Files:
**⚙️ CodeRabbit configuration file
Files:
⚙️ CodeRabbit configuration file
Files:
🧠 Learnings (70)📚 Learning: 2025-12-15T12:33:06.686ZApplied to files:
📚 Learning: 2026-01-14T04:08:23.032ZApplied to files:
📚 Learning: 2026-01-18T09:44:17.044ZApplied to files:
📚 Learning: 2026-01-27T17:18:49.973ZApplied to files:
📚 Learning: 2026-02-23T16:31:34.505ZApplied to files:
📚 Learning: 2026-02-25T10:52:09.679ZApplied to files:
📚 Learning: 2026-03-19T10:36:59.023ZApplied to files:
📚 Learning: 2026-03-25T11:24:07.687ZApplied to files:
📚 Learning: 2026-03-31T08:35:22.802ZApplied to files:
📚 Learning: 2026-03-31T10:39:33.409ZApplied to files:
📚 Learning: 2026-04-02T09:03:57.004ZApplied to files:
📚 Learning: 2026-04-14T13:00:57.514ZApplied to files:
📚 Learning: 2026-04-14T16:15:31.065ZApplied to files:
📚 Learning: 2026-04-14T16:15:33.012ZApplied to files:
📚 Learning: 2026-04-21T19:08:39.771ZApplied to files:
📚 Learning: 2026-04-26T11:44:20.150ZApplied to files:
📚 Learning: 2026-04-27T15:40:31.167ZApplied to files:
📚 Learning: 2026-05-03T14:47:13.096ZApplied to files:
📚 Learning: 2026-05-05T17:27:32.109ZApplied to files:
📚 Learning: 2026-05-05T18:28:01.097ZApplied to files:
📚 Learning: 2026-05-07T12:34:42.589ZApplied to files:
📚 Learning: 2026-05-08T12:31:26.895ZApplied to files:
📚 Learning: 2026-05-12T18:18:20.607ZApplied to files:
📚 Learning: 2026-05-25T09:13:27.011ZApplied to files:
📚 Learning: 2026-05-25T09:57:03.042ZApplied to files:
📚 Learning: 2026-05-28T12:55:07.435ZApplied to files:
📚 Learning: 2026-05-29T07:28:31.170ZApplied to files:
📚 Learning: 2026-06-01T13:36:34.844ZApplied to files:
📚 Learning: 2026-06-01T14:00:39.271ZApplied to files:
📚 Learning: 2026-06-02T21:16:58.118ZApplied to files:
📚 Learning: 2026-06-11T11:56:02.760ZApplied to files:
📚 Learning: 2026-06-15T11:26:05.202ZApplied to files:
📚 Learning: 2026-06-22T16:28:10.287ZApplied to files:
📚 Learning: 2026-06-23T09:59:19.816ZApplied to files:
📚 Learning: 2025-12-22T16:27:40.244ZApplied to files:
📚 Learning: 2026-01-07T09:52:12.342ZApplied to files:
📚 Learning: 2026-01-18T13:18:48.808ZApplied to files:
📚 Learning: 2026-01-18T14:51:50.846ZApplied to files:
📚 Learning: 2026-01-29T05:30:13.982ZApplied to files:
📚 Learning: 2026-02-02T17:41:12.759ZApplied to files:
📚 Learning: 2026-02-03T07:34:34.184ZApplied to files:
📚 Learning: 2026-02-10T15:04:14.799ZApplied to files:
📚 Learning: 2026-02-25T11:00:02.013ZApplied to files:
📚 Learning: 2026-03-29T13:51:25.599ZApplied to files:
📚 Learning: 2026-01-12T11:24:13.825ZApplied to files:
📚 Learning: 2026-01-12T14:25:05.723ZApplied to files:
📚 Learning: 2026-01-20T01:03:13.139ZApplied to files:
📚 Learning: 2026-01-21T21:26:41.805ZApplied to files:
📚 Learning: 2026-01-25T13:18:21.675ZApplied to files:
📚 Learning: 2026-02-18T06:35:39.536ZApplied to files:
📚 Learning: 2026-02-23T16:33:22.070ZApplied to files:
📚 Learning: 2026-03-17T01:32:02.617ZApplied to files:
📚 Learning: 2026-03-17T01:32:02.617ZApplied to files:
📚 Learning: 2026-05-04T13:45:29.122ZApplied to files:
📚 Learning: 2026-05-04T13:45:33.892ZApplied to files:
📚 Learning: 2026-05-05T17:01:15.294ZApplied to files:
📚 Learning: 2026-05-08T12:49:20.694ZApplied to files:
📚 Learning: 2026-05-12T05:10:24.601ZApplied to files:
📚 Learning: 2026-05-13T19:23:09.603ZApplied to files:
📚 Learning: 2026-05-18T06:30:56.781ZApplied to files:
📚 Learning: 2026-05-18T06:31:12.015ZApplied to files:
📚 Learning: 2026-05-18T06:31:15.083ZApplied to files:
📚 Learning: 2026-05-18T06:31:20.848ZApplied to files:
📚 Learning: 2026-05-18T09:09:09.479ZApplied to files:
📚 Learning: 2026-05-19T07:48:17.119ZApplied to files:
📚 Learning: 2026-05-19T07:48:17.119ZApplied to files:
📚 Learning: 2026-05-26T15:52:31.613ZApplied to files:
📚 Learning: 2026-06-21T20:28:07.727ZApplied to files:
📚 Learning: 2026-05-03T15:38:09.624ZApplied to files:
📚 Learning: 2026-06-15T10:56:21.758ZApplied to files:
🔇 Additional comments (2)
📝 WalkthroughWalkthrough
ChangesVIRT_ALERTS_LIST grouping and expansion
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related issues
✨ Finishing Touches🧪 Generate unit tests (beta)
|
|
/build-and-push-container |
|
New container for quay.io/openshift-cnv/openshift-virtualization-tests:pr-5361 published |
|
/verified All tests passed for PR #5361. Execution details |
Test execution plan request detailsCRITICAL: You MUST post an inline review comment on the first changed line of the first file. As an expert software testing engineer, analyze all modified files in this PR and create a targeted test execution plan. Analysis Requirements:
Output rules: Your deliverable: Test Execution Plan
Use these formats:
Real test commands (MANDATORY when changes affect session/runtime code): When the affected code runs at session/collection time (conftest fixtures, pytest plugins,
Example output for a session-startup fix: Guidelines:
Hardware-Related Checks (SR-IOV, GPU, DPDK): When PR modifies fixtures for hardware-specific resources:
CRITICAL WORKFLOW COMPLETION RULES: When responding to this test execution plan request, you MUST follow these rules EXACTLY:
ABSOLUTE PROHIBITIONS (violating these creates empty/meaningless reviews):
Remember: The pull request review is visible to users. Additional comments are redundant noise. CRITICAL — Verification rules for smoke and gating decisions: |
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
# Get PR diff to find first changed line
gh pr diff 5361 --repo RedHatQE/openshift-virtualization-tests | head -60
# Find usages of VIRT_ALERTS_LIST
rg -n 'VIRT_ALERTS_LIST' tests/ --type py
# Find smoke-marked test files
rg -l '`@pytest.mark.smoke`' tests/ --type py
# Find gating-marked test files
rg -l '`@pytest.mark.gating`' tests/ --type py
# Look at the observability test file that uses alerts
fd 'test_healthy_cluster_no_alerts.py' tests/Length of output: 5789 🏁 Script executed: #!/bin/bash
# Post inline review comment on first changed line (line 7, RIGHT side) of tests/observability/constants.py
# Using GitHub REST API to create a pull request review with an inline comment
gh api \
--method POST \
repos/RedHatQE/openshift-virtualization-tests/pulls/5361/reviews \
--field body="" \
--field event="COMMENT" \
--field "comments[][path]=tests/observability/constants.py" \
--field "comments[][line]=7" \
--field "comments[][side]=RIGHT" \
--field "comments[][body]=**Test Execution Plan**
---
**Run smoke tests: False**
No smoke-marked test imports or depends on \`VIRT_ALERTS_LIST\`.
**Run gating tests: True**
Dependency path: \`tests/observability/test_healthy_cluster_no_alerts.py\` → imports \`VIRT_ALERTS_LIST\` directly from \`tests/observability/constants.py\` (line 14: \`verify_no_listed_alerts_on_cluster(prometheus=prometheus, alerts_list=VIRT_ALERTS_LIST)\`)
**Affected tests to run**
- \`tests/observability/test_healthy_cluster_no_alerts.py\` (gating)"Length of output: 2892 |
|
/approve |
|
Successfully removed PR tag: quay.io/openshift-cnv/openshift-virtualization-tests:pr-5361. |
|
New container for quay.io/openshift-cnv/openshift-virtualization-tests:latest published |
|
/cherry-pick cnv-4.22 |
|
Cherry-picked PR Update VIRT_ALERTS_LIST with new and missing virt component alerts into cnv-4.22: #5430 |
What this PR does / why we need it:
Add 5 new alerts from CNV-71204 (VirtHandlerDown, LowReadyVirtAPICount, NoReadyVirtAPI, LowReadyVirtHandlerCount, NoReadyVirtHandler) and 3 alerts that were previously missing (VirtControllerDown, LowVirtAPICount, LowVirtControllersCount). Remove duplicate LowVirtOperatorCount entry and organize list by component.
jira-ticket: CNV-71204
assisted by: claude code claude-opus-4-6
Which issue(s) this PR fixes:
Special notes for reviewer:
jira-ticket:
https://redhat.atlassian.net/browse/CNV-91215
Summary by CodeRabbit