CherryPicked: [cnv-4.22] Handle missing cpu-arch config gracefully in pytest fixture#5427
Merged
Merged
Conversation
The current implementation of checking the `cpu-arch` argument only supports a single value, however for multi-arch tests it is required to pass a list of architectures (`--cpu-arch=amd64,arm64`)." The fixture now uses dict.get() instead of direct indexing to handle missing cpu_arch gracefully. `cpu_arch` is not set for multi-arch cluster runs now (by design), and this fix handles the KeyError failure. Assisted-by: Claude Code <noreply@anthropic.com> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit ## Summary of changes * **New Features** * Added architecture-aware selection for Fedora container images and container image digests, ensuring VM disk/volume provisioning and images match the resolved VM architecture (including multi-arch behavior). * **Bug Fixes** * Improved cluster CPU architecture reporting to use the cluster configuration directly and avoid missing/undefined values. * **Tests** * Updated fixtures to handle optional CPU architecture configuration safely when the key is absent. <!-- end of auto-generated comment: release notes by coderabbit.ai --> Signed-off-by: Yossi Segev <ysegev@redhat.com>
openshift-virtualization-qe-bot
added
tox:verify-tc-requirement-polarion:running
|
Report bugs in Issues Welcome! 🎉This pull request will be automatically processed with the following features: 🔄 Automatic Actions
📋 Available CommandsPR Status Management
Review & Approval
Testing & Validation
Container Operations
Cherry-pick Operations
Branch Management
Custom Commands
Label Management
✅ Merge RequirementsThis PR will be automatically approved when the following conditions are met:
📊 Review ProcessApprovers and ReviewersApprovers:
Reviewers:
Available Labels
AI Features
Security Checks
💡 Tips
For more information, please refer to the project documentation or contact the maintainers. |
openshift-virtualization-qe-bot
requested review from
RoniKishner,
nirdothan and
servolkov
openshift-virtualization-qe-bot
requested review from
Anatw,
azhivovk,
dshchedr,
frenzyfriday,
rnetser and
vsibirsk
servolkov
approved these changes
Jun 29, 2026
Contributor
|
/retest build-container |
Contributor
|
/verified Verified by:
|
dshchedr
approved these changes
Jun 30, 2026
Contributor
|
/lgtm |
Collaborator
|
/approve |
|
New container for quay.io/openshift-cnv/openshift-virtualization-tests:cnv-4.22 published |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick from
mainbranch, original PR: #5285, PR owner: yossisegev