Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/widgetastic/browser.py
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ def logger(self):
"""Logger with prepended plugin name."""
return create_widget_logger(type(self).__name__, self.browser.logger)

def ensure_page_safe(self, timeout: str = "10s") -> None:
def ensure_page_safe(self, timeout=10) -> None:

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: Consider keeping a concrete type annotation for timeout now that it is numeric seconds.

Since the default is now a bare 10, this parameter is effectively “seconds as a number”. A concrete annotation like timeout: int | float = 10 would improve static checking and make it clear that string formats like "10s" are no longer accepted, which helps callers migrating to the new convention.

Suggested change
def ensure_page_safe(self, timeout=10) -> None:
def ensure_page_safe(self, timeout: int | float = 10) -> None:

# THIS ONE SHOULD ALWAYS USE JAVASCRIPT ONLY, NO OTHER SELENIUM INTERACTION

def _check():
Expand Down Expand Up @@ -431,7 +431,7 @@ def _element_lookup():
try:
result = wait_for(
_element_lookup,
num_sec=timeout,
timeout=timeout,
delay=delay,
fail_condition=lambda elements: not bool(elements),
fail_func=self.plugin.ensure_page_safe if ensure_page_safe else None,
Expand Down
2 changes: 1 addition & 1 deletion src/widgetastic/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -763,7 +763,7 @@ class WaitFillViewStrategy(DefaultFillViewStrategy):
So such strategy gives next widget some time to turn up.
"""

def __init__(self, respect_parent=False, wait_widget="5s"):
def __init__(self, respect_parent=False, wait_widget=5):
self.wait_widget = wait_widget
super().__init__(respect_parent=respect_parent)

Expand Down
2 changes: 1 addition & 1 deletion src/widgetastic/widget/base.py
Original file line number Diff line number Diff line change
Expand Up @@ -523,7 +523,7 @@ def is_enabled(self):
return self.browser.element(self).is_enabled()

@logged()
def wait_displayed(self, timeout="10s", delay=0.2):
def wait_displayed(self, timeout=10, delay=0.2):
"""Wait for the element to be displayed. Uses the :py:meth:`is_displayed`

Args:
Expand Down
Loading